From: Rui Miguel Silva <rmfrfs@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-leds@vger.kernel.org,
jacek.anaszewski@gmail.com, laurent.pinchart@ideasonboard.com,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
viresh.kumar@linaro.org
Subject: Re: [PATCH v2 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators
Date: Wed, 9 Aug 2017 17:09:12 +0100 [thread overview]
Message-ID: <20170809160912.GC10002@arch-late.localdomain> (raw)
In-Reply-To: <20170809111555.30147-3-sakari.ailus@linux.intel.com>
Hi,
On Wed, Aug 09, 2017 at 02:15:54PM +0300, Sakari Ailus wrote:
> The V4L2 flash interface allows controlling multiple LEDs through a single
> sub-devices if, and only if, these LEDs are of different types. This
> approach scales badly for flash controllers that drive multiple flash LEDs
> or for LED specific associations. Essentially, the original assumption of a
> LED driver chip that drives a single flash LED and an indicator LED is no
> longer valid.
>
> Address the matter by registering one sub-device per LED.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> drivers/leds/leds-aat1290.c | 4 +-
> drivers/leds/leds-max77693.c | 4 +-
> drivers/media/v4l2-core/v4l2-flash-led-class.c | 113 +++++++++++++++----------
> drivers/staging/greybus/light.c | 23 +++--
For greybus/light:
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
---
Cheers,
Rui
next prev parent reply other threads:[~2017-08-09 16:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 11:15 [PATCH v2 0/3] Create sub-device per LED Sakari Ailus
2017-08-09 11:15 ` [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register Sakari Ailus
2017-08-09 13:20 ` Rui Miguel Silva
2017-08-09 15:36 ` Sakari Ailus
2017-08-09 16:06 ` Rui Miguel Silva
2017-08-10 13:02 ` Hans Verkuil
2017-08-10 13:09 ` Hans Verkuil
2017-08-10 13:56 ` Sakari Ailus
2017-08-10 14:43 ` Rui Miguel Silva
2017-08-09 11:15 ` [PATCH v2 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators Sakari Ailus
2017-08-09 16:09 ` Rui Miguel Silva [this message]
2017-08-10 13:18 ` Hans Verkuil
2017-08-09 11:15 ` [PATCH v2 3/3] v4l2-flash-led-class: Document v4l2_flash_init() references Sakari Ailus
2017-08-10 13:16 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809160912.GC10002@arch-late.localdomain \
--to=rmfrfs@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jacek.anaszewski@gmail.com \
--cc=johan@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox