From: Pavel Machek <pavel@ucw.cz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS depdendency
Date: Fri, 8 Sep 2017 14:35:13 +0200 [thread overview]
Message-ID: <20170908123513.GM18365@amd> (raw)
In-Reply-To: <20170905071345.3807685-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
On Tue 2017-09-05 09:13:20, Arnd Bergmann wrote:
> We get a link error when V4L2_FLASH_LED_CLASS=m and AS3645A is built-in:
>
> drivers/leds/leds-as3645a.o: In function `as3645a_v4l2_setup':
> leds-as3645a.c:(.text+0x258): undefined reference to `v4l2_flash_init'
> leds-as3645a.c:(.text+0x284): undefined reference to `v4l2_flash_indicator_init'
> leds-as3645a.c:(.text+0x2a4): undefined reference to `v4l2_flash_release'
> drivers/leds/leds-as3645a.o: In function `as3645a_remove':
> leds-as3645a.c:(.text+0x784): undefined reference to `v4l2_flash_release'
>
> This adds the same Kconfig dependency that the other V4L2 flash
> drivers in drivers/leds use, to avoid that broken configuration.
>
> Fixes: a56ba8fbcb55 ("media: leds: as3645a: Add LED flash class driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2017-09-08 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 7:13 [PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS depdendency Arnd Bergmann
2017-09-05 19:24 ` Jacek Anaszewski
2017-09-05 20:18 ` Sakari Ailus
2017-09-08 12:35 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908123513.GM18365@amd \
--to=pavel@ucw.cz \
--cc=arnd@arndb.de \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mchehab@s-opensource.com \
--cc=rpurdie@rpsys.net \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).