From: Pavel Machek <pavel@ucw.cz>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] as3645a: Use integer numbers for parsing LEDs
Date: Fri, 8 Sep 2017 15:38:41 +0200 [thread overview]
Message-ID: <20170908133841.GS18365@amd> (raw)
In-Reply-To: <20170908132333.rlhurlwrzq43ss2k@valkosipuli.retiisi.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]
On Fri 2017-09-08 16:23:34, Sakari Ailus wrote:
> Hi Pavel,
>
> Thanks for the review.
>
> On Fri, Sep 08, 2017 at 03:17:58PM +0200, Pavel Machek wrote:
> > On Fri 2017-09-08 15:42:13, Sakari Ailus wrote:
> > > Use integer numbers for LEDs, 0 is the flash and 1 is the indicator.
> > >
> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> >
> > Dunno. Old code is shorter, old device tree is shorter, ... IMO both
> > versions are fine, because the LEDs are really different. Do we have
> > documentation somewhere saying that reg= should be used for this? Are
> > you doing this for consistency?
>
> Well, actually for ACPI support. :-) It requires less driver changes this
> way. See 17th and 18th patches in "[PATCH v9 00/23] Unified fwnode endpoint
> parser, async sub-device notifier support, N9 flash DTS".
ACPI, I hate ACPI.
> A number of chips have LED binding that is aligned, see e.g.
> Documentation/devicetree/bindings/leds/leds-bcm6328.txt .
Ok, yes, that's common way LED controllers are handled. Usually all
the LEDs are "same", but...
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-09-08 13:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 12:42 [PATCH 0/3] AS3645A fixes Sakari Ailus
2017-09-08 12:42 ` [PATCH 2/3] dt: bindings: as3645a: Use LED number to refer to LEDs Sakari Ailus
2017-09-13 20:28 ` Rob Herring
[not found] ` <20170908124213.18904-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-08 12:42 ` [PATCH 1/3] as3645a: Use ams,input-max-microamp as documented in DT bindings Sakari Ailus
2017-09-08 13:14 ` Pavel Machek
2017-09-08 12:42 ` [PATCH 3/3] as3645a: Use integer numbers for parsing LEDs Sakari Ailus
2017-09-08 13:17 ` Pavel Machek
2017-09-08 13:23 ` Sakari Ailus
2017-09-08 13:38 ` Pavel Machek [this message]
2017-09-08 13:45 ` Sakari Ailus
2017-09-08 19:51 ` [PATCH 0/3] AS3645A fixes Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908133841.GS18365@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).