* Splitting led drivers to subdirectories?
@ 2017-09-12 12:54 Pavel Machek
2017-09-12 19:11 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Machek @ 2017-09-12 12:54 UTC (permalink / raw)
To: jacek.anaszewski, linux-leds, kernel list
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
Hi!
Is it time to start splitting drivers into subdirectories?
I'd quite like to see drivers/leds/i2c/ and drivers/leds/flash/ . That
way it is easier to look at related drivers for inspiration...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Splitting led drivers to subdirectories?
2017-09-12 12:54 Splitting led drivers to subdirectories? Pavel Machek
@ 2017-09-12 19:11 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2017-09-12 19:11 UTC (permalink / raw)
To: Pavel Machek, linux-leds, kernel list
Hi,
On 09/12/2017 02:54 PM, Pavel Machek wrote:
> Hi!
>
> Is it time to start splitting drivers into subdirectories?
>
> I'd quite like to see drivers/leds/i2c/ and drivers/leds/flash/ . That
> way it is easier to look at related drivers for inspiration...
These categorization would be inconsistent - i2c is a bus, and
flash is a LED function. Moreover, not all devices are driven through
buses, some of them via gpio, MMIO or even as2cwire like in case of
leds-aat1290. Do we want to split the drivers like that? It would
generate only unnecessary noise IMHO.
We could go for splitting drivers to LED and LED flash class,
but the former is just a subset of the latter, so it would be
also not accurate.
Effectively I propose to apply the "leave well alone" rule here :-)
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-12 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-12 12:54 Splitting led drivers to subdirectories? Pavel Machek
2017-09-12 19:11 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).