Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer

Pavel Machek
2017-09-13T20:20:32Z

[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]

Hi!

> These patch series add the LED_BRIGHTNESS_FAST flag support for
> ledtrig-transient to use hrtimer so that platforms with high-resolution timer
> support can have better accuracy in the trigger duration timing. The need for
> this support is driven by the fact that Android has removed the timed_ouput [1]
> and is now using led-trigger for handling vibrator control which requires the
> timer to be accurate up to a millisecond. However, this flag support would also
> allow hrtimer to co-exist with the ktimer without causing warning to the
> existing drivers [2].

NAK.

LEDs do not need extra overhead, and vibrator control should not go
through LED subsystem.

Input subsystem includes support for vibrations and force
feedback. Please use that instead.

Pavel

> David Lin (3):
> leds: Replace flags bit shift with BIT() macros
> leds: Add the LED_BRIGHTNESS_FAST flag
> led: ledtrig-transient: add support for hrtimer
>
> Documentation/leds/leds-class.txt | 5 +++
> drivers/leds/trigger/ledtrig-transient.c | 59 +++++++++++++++++++++++++++++---
> include/linux/leds.h | 19 +++++-----
> 3 files changed, 69 insertions(+), 14 deletions(-)
>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]