From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: linux-input@vger.kernel.org, David Lin <dtwlin@google.com>,
corbet@lwn.net, rpurdie@rpsys.net, hdegoede@redhat.com,
gregkh@linuxfoundation.org, robh@kernel.org, romlem@google.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer
Date: Wed, 20 Sep 2017 13:15:26 +0200 [thread overview]
Message-ID: <20170920111526.GA3097@amd> (raw)
In-Reply-To: <a17f76a4-9c9b-6154-6b5e-d30fd499efa7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]
On Mon 2017-09-18 22:43:40, Jacek Anaszewski wrote:
> Hi,
>
> On 09/17/2017 07:50 PM, Pavel Machek wrote:
> > Hi!
> >
> >>>> Do you think such an improvement could be harmful in some way,
> >>>> even if it was made optional?
> >>>
> >>> Of course, we can make LED timing accurate down to microseconds. It will
> >>> mean increased overhead -- for "improvement" human can not perceive.
> >>>
> >>> If someone has problems with LED delays not being accurate enough... we
> >>> may want to fix it. But that is not the case here, is it?
> >>
> >> AFAIR David was mentioning that the hr_timer support is perceivable
> >
> > He said that hr_timer support is perceivable _when he is driving
> > vibration motor_. Which he should not do in the first place.
> >
> > Yes, if the difference is perceivable with LED in non-crazy
> > configuration (*), we can take the patch. Is it? Do we have someone
> > not from Google observing it?
> >
> > (*) emulating PWM using blink trigger counts as "crazy" :-)
>
> How about adding CONFIG_LED_TRIGGERS_HR_TIMER_SUPPORT, guarding the
> hr timer support in triggers (timer trigger could also benefit from it)
> with it, and adding "(EXPERIMENTAL)" tag to the config description?
Why would we want to add code in the LED subsystem that is useless for
LEDs?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-09-20 11:15 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 17:53 [PATCH v2 0/3] led: ledtrig-transient: add support for hrtimer David Lin
2017-09-13 17:53 ` [PATCH v2 1/3] leds: Replace flags bit shift with BIT() macros David Lin
2017-09-14 19:43 ` Jacek Anaszewski
2017-09-13 17:53 ` [PATCH v2 2/3] leds: Add the LED_BRIGHTNESS_FAST flag David Lin
2017-09-13 17:54 ` [PATCH v2 3/3] led: ledtrig-transient: add support for hrtimer David Lin
2017-09-13 20:20 ` [PATCH v2 0/3] " Pavel Machek
2017-09-13 21:20 ` David Lin
2017-09-13 21:34 ` Pavel Machek
2017-09-14 17:31 ` David Lin
2017-09-14 19:42 ` Pavel Machek
2017-09-14 19:31 ` Jacek Anaszewski
2017-09-14 19:38 ` David Lin
2017-09-14 20:03 ` Jacek Anaszewski
2017-09-14 20:58 ` Vibrations in input vs. LED was " Pavel Machek
2017-09-15 18:34 ` Dmitry Torokhov
2017-09-15 21:55 ` Jacek Anaszewski
2017-09-15 22:30 ` Dmitry Torokhov
2017-09-17 16:41 ` Jacek Anaszewski
2017-09-17 18:22 ` Pavel Machek
2017-09-17 21:15 ` Pavel Machek
2017-09-18 20:50 ` Jacek Anaszewski
2017-09-18 22:29 ` Dmitry Torokhov
2017-09-19 20:45 ` Jacek Anaszewski
2017-09-19 21:07 ` Dmitry Torokhov
2017-09-20 19:31 ` Jacek Anaszewski
2017-09-20 11:29 ` Pavel Machek
2017-09-20 20:08 ` Jacek Anaszewski
2017-10-06 11:48 ` Pavel Machek
2017-10-06 20:57 ` Jacek Anaszewski
2017-09-20 11:26 ` Pavel Machek
2017-09-28 5:03 ` David Lin
2017-09-28 5:43 ` Dmitry Torokhov
2017-09-28 19:22 ` David Lin
2017-10-05 0:40 ` Dmitry Torokhov
2017-09-16 12:59 ` Pavel Machek
2017-09-15 21:55 ` Jacek Anaszewski
2017-09-16 1:58 ` Pavel Machek
2017-09-17 16:41 ` Jacek Anaszewski
2017-09-17 17:50 ` Pavel Machek
2017-09-18 20:43 ` Jacek Anaszewski
2017-09-20 11:15 ` Pavel Machek [this message]
2017-09-20 18:44 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920111526.GA3097@amd \
--to=pavel@ucw.cz \
--cc=corbet@lwn.net \
--cc=dtwlin@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
--cc=romlem@google.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).