Re: [PATCH] leds: pm8058: Make ledtype pointer sized type

Jacek Anaszewski
2017-11-30T22:02:51Z

On 11/30/2017 09:31 AM, Lee Jones wrote:
> On Thu, 30 Nov 2017, Lee Jones wrote:
>
>> On Wed, 29 Nov 2017, Bjorn Andersson wrote:
>>
>>> The pointer returned by of_device_get_match_data() doesn't have the same
>>> size as u32 on 64-bit architectures, causing issues when compile testing
>>> the driver on such platform. Make ledtype unsigned long instead, to
>>> solve this problem.
>>>
>>> Fixes: 7f866986e705 ("leds: add PM8058 LEDs driver")
>>> Cc: Linus Walleij <linus.walleij@linaro.org>
>>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>>> ---
>>> drivers/leds/leds-pm8058.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Hi Bjorn,
>>
>> (Nice to see you) :)
>>
>> I'm going to apply this *before* Linus' fix.
>>
>> Applied, thanks.
>
> After I rx an Ack from Richard, Jacek or Pavel of course. :)
>
> Will send a pull-request.

Huh? This is for LED subsystem AFAICS.

--
Best regards,
Jacek Anaszewski