From: Pavel Machek <pavel@ucw.cz>
To: Sasha Levin <Alexander.Levin@microsoft.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Matthieu CASTET <matthieu.castet@parrot.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>
Subject: Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0
Date: Sun, 4 Feb 2018 10:05:31 +0100 [thread overview]
Message-ID: <20180204090531.GA29468@amd> (raw)
In-Reply-To: <20180204003029.2lkcmh6wvzpnlrls@sasha-lappy>
[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]
On Sun 2018-02-04 00:30:36, Sasha Levin wrote:
> On Sat, Feb 03, 2018 at 09:35:26PM +0100, Pavel Machek wrote:
> >On Sat 2018-02-03 18:00:59, Sasha Levin wrote:
> >> From: Matthieu CASTET <matthieu.castet@parrot.com>
> >>
> >> [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ]
> >>
> >> With the current code, the following sequence won't work :
> >> echo timer > trigger
> >>
> >> echo 0 > delay_off
> >> * at this point we call
> >> ** led_delay_off_store
> >> ** led_blink_set
> >> *** stop timer
> >> ** led_blink_setup
> >> ** led_set_software_blink
> >> *** if !delay_on, led off
> >> *** if !delay_off, set led_set_brightness_nosleep <--- LED_BLINK_SW is set but timer is stop
> >> *** otherwise start timer/set LED_BLINK_SW flag
> >>
> >> echo xxx > brightness
> >> * led_set_brightness
> >> ** if LED_BLINK_SW
> >> *** if brightness=0, led off
> >> *** else apply brightness if next timer <--- timer is stop, and will never apply new setting
> >> ** otherwise set led_set_brightness_nosleep
> >>
> >> To fix that, when we delete the timer, we should clear LED_BLINK_SW.
> >
> >Can you run the tests on the affected stable kernels? I have feeling
> >that the problem described might not be present there.
>
> Hm, I don't seem to have HW to test that out. Maybe someone else does?
Why are you submitting patches you have no way to test?
Plus... you don't have PC keyboard? You don't have thinkpad notebook?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-02-04 9:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180203180015.29073-1-alexander.levin@microsoft.com>
2018-02-03 18:00 ` [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0 Sasha Levin
2018-02-03 20:35 ` Pavel Machek
2018-02-04 0:30 ` Sasha Levin
2018-02-04 9:05 ` Pavel Machek [this message]
2018-02-04 11:15 ` Greg KH
2018-02-04 17:17 ` Pavel Machek
2018-02-06 2:02 ` Sasha Levin
2018-02-06 20:44 ` Jacek Anaszewski
2018-03-12 15:00 ` Matthias Schiffer
2018-03-12 15:28 ` Greg KH
2018-03-12 15:45 ` Matthias Schiffer
2018-03-12 20:20 ` Jacek Anaszewski
2018-03-13 7:50 ` Pavel Machek
2018-03-13 9:37 ` Greg KH
2018-03-13 13:27 ` Pavel Machek
2018-03-13 19:44 ` Jacek Anaszewski
2018-03-16 12:46 ` Greg KH
2018-02-06 21:51 ` Pavel Machek
2018-02-04 15:49 ` Sasha Levin
2018-02-04 17:31 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180204090531.GA29468@amd \
--to=pavel@ucw.cz \
--cc=Alexander.Levin@microsoft.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=matthieu.castet@parrot.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).