From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sakari Ailus <sakari.ailus@iki.fi>, Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH/RFC] DT: leds: Fix 'label' property description and add 'colour' property
Date: Fri, 2 Mar 2018 13:51:57 +0100 [thread overview]
Message-ID: <20180302125157.GC28931@amd> (raw)
In-Reply-To: <82dc0ed3-f4fe-d8a2-65ea-4212770b78e7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]
Hi!
> >> Also.. it would be good to start pushing for more consistency in the
> >> labels: I have these on the thinkpad:
> >>
> >> input5::scrolllock/ tpacpi::dock_status2/ tpacpi::unknown_led/
> >> mmc0::/ tpacpi:green:batt/ tpacpi::unknown_led2/
> >> phy0-led/ tpacpi:orange:batt/ tpacpi::unknown_led3/
> >> tpacpi::bay_active/ tpacpi::power/
>
> In effect it looks like we should drop devicename section from
> the LED class devicename pattern, label should describe only
> LED function and additional color property could be introduced,
> to be concatenated with LED function as a final LED class device
> name.
Well, the device name makes sense if the LED is not on the "main"
device.
I do have "scrollock" led on internal keyboard, and scollock led on
USB keyboard... it is good to be able to tell which is which.
But yes, IMO it makes sense to move from
"as4134::backlight" to "screen::backlight" or something, and have it
standard across the machines.
tpacpi:: is not useful prefix for a led name. mmc0:: and input5:: are
quite useful.
Similary, as5124::flash is not useful, but main_camera::flash or
video5::flash might be.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-03-02 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 21:50 [PATCH/RFC] DT: leds: Fix 'label' property description and add 'colour' property Jacek Anaszewski
2017-12-04 10:43 ` Pavel Machek
2017-12-05 19:52 ` Jacek Anaszewski
2017-12-11 16:27 ` Rob Herring
2017-12-14 21:35 ` Jacek Anaszewski
[not found] ` <82dc0ed3-f4fe-d8a2-65ea-4212770b78e7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-17 12:49 ` Jacek Anaszewski
2018-03-02 12:51 ` Pavel Machek [this message]
2017-12-08 16:01 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302125157.GC28931@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).