From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH/RFC] DT: leds: Fix 'label' property description and add 'colour' property Date: Fri, 2 Mar 2018 13:51:57 +0100 Message-ID: <20180302125157.GC28931@amd> References: <1512251410-6084-1-git-send-email-jacek.anaszewski@gmail.com> <20171204104351.GA6611@amd> <82dc0ed3-f4fe-d8a2-65ea-4212770b78e7@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JWEK1jqKZ6MHAcjA" Return-path: Content-Disposition: inline In-Reply-To: <82dc0ed3-f4fe-d8a2-65ea-4212770b78e7@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Jacek Anaszewski Cc: Rob Herring , Linux LED Subsystem , "linux-kernel@vger.kernel.org" , Sakari Ailus , Dan Murphy List-Id: linux-leds@vger.kernel.org --JWEK1jqKZ6MHAcjA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >> Also.. it would be good to start pushing for more consistency in the > >> labels: I have these on the thinkpad: > >> > >> input5::scrolllock/ tpacpi::dock_status2/ tpacpi::unknown_led/ > >> mmc0::/ tpacpi:green:batt/ tpacpi::unknown_led2/ > >> phy0-led/ tpacpi:orange:batt/ tpacpi::unknown_led3/ > >> tpacpi::bay_active/ tpacpi::power/ >=20 > In effect it looks like we should drop devicename section from > the LED class devicename pattern, label should describe only > LED function and additional color property could be introduced, > to be concatenated with LED function as a final LED class device > name. Well, the device name makes sense if the LED is not on the "main" device. I do have "scrollock" led on internal keyboard, and scollock led on USB keyboard... it is good to be able to tell which is which. But yes, IMO it makes sense to move from "as4134::backlight" to "screen::backlight" or something, and have it standard across the machines. tpacpi:: is not useful prefix for a led name. mmc0:: and input5:: are quite useful. Similary, as5124::flash is not useful, but main_camera::flash or video5::flash might be. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --JWEK1jqKZ6MHAcjA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlqZSO0ACgkQMOfwapXb+vI2GgCfQLf+jK8mwh8TNm8ezfCIQcni 3pcAoIXFbIei1QSB1mVFqGlD2F0LJU+e =LbEP -----END PGP SIGNATURE----- --JWEK1jqKZ6MHAcjA--