From: Pavel Machek <pavel@ucw.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Ben Hutchings <ben.hutchings@codethink.co.uk>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
Matthieu CASTET <matthieu.castet@parrot.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0
Date: Thu, 8 Mar 2018 19:04:04 +0100 [thread overview]
Message-ID: <20180308180403.GA16940@amd> (raw)
In-Reply-To: <20180308172401.GB22224@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]
On Thu 2018-03-08 09:24:01, Greg Kroah-Hartman wrote:
> On Wed, Mar 07, 2018 at 09:39:08PM +0100, Jacek Anaszewski wrote:
> > Hi Ben,
> >
> > On 03/07/2018 04:32 PM, Ben Hutchings wrote:
> > > On Fri, 2018-03-02 at 09:51 +0100, Greg Kroah-Hartman wrote:
> > >> 4.4-stable review patch. If anyone has any objections, please let me
> > >> know.
> > >>
> > >> ------------------
> > >>
> > >> From: Matthieu CASTET <matthieu.castet@parrot.com>
> > >>
> > >>
> > >> [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ]
> > >>
> > >> With the current code, the following sequence won't work :
> > >> echo timer > trigger
> > >>
> > >> echo 0 > delay_off
> > >> * at this point we call
> > >> ** led_delay_off_store
> > >> ** led_blink_set
> > > [...]
> > >
> > > The commit message got cut truncated here, which resulted in addresses
> > > being omitted when it was sent out for review. The upstream commit
> > > message refers to a LED_BLINK_SW flag which is not used in 4.4. So
> > > this fix probably isn't needed, though I can't tell whether it does any
> > > harm.
> >
> > We discussed it in [0]. This patch is not needed for 4.4 and what's
> > more more it is harmful. It introduces a bug, fixed in [1].
> >
> > [0] https://lkml.org/lkml/2018/2/6/726
> > [1[ https://patchwork.kernel.org/patch/10253933/
>
> So, did I mess something up here? Am I missing some patch that I need
> to apply, or do I need to revert something?
Well, patch [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0
is not suitable for -stable. It is not needed there.
(And it is also buggy and does not fix serious-enough problem to
warrant -stable).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-03-08 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180302084435.842679610@linuxfoundation.org>
[not found] ` <20180302084437.007951262@linuxfoundation.org>
2018-03-07 15:32 ` [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0 Ben Hutchings
2018-03-07 20:39 ` Jacek Anaszewski
2018-03-08 17:24 ` Greg Kroah-Hartman
2018-03-08 18:04 ` Pavel Machek [this message]
2018-03-08 20:48 ` Jacek Anaszewski
2018-03-09 1:09 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308180403.GA16940@amd \
--to=pavel@ucw.cz \
--cc=ben.hutchings@codethink.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=matthieu.castet@parrot.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).