From: Pavel Machek <pavel@ucw.cz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
y2038@lists.linaro.org, Kees Cook <keescook@chromium.org>,
Willy Tarreau <w@1wt.eu>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: ledtrig-activity: use ktime_get_boot_ns()
Date: Mon, 18 Jun 2018 17:07:15 +0200 [thread overview]
Message-ID: <20180618150715.GA30470@amd> (raw)
In-Reply-To: <20180618144210.72367-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]
Hi!
> get_monotonic_boottime() is deprecated, so let's convert this to
> the simpler ktime_get_boot_ns().
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Have you tested it?
> diff --git a/drivers/leds/trigger/ledtrig-activity.c b/drivers/leds/trigger/ledtrig-activity.c
> index 5081894082bd..589c1bc4d0b9 100644
> --- a/drivers/leds/trigger/ledtrig-activity.c
> +++ b/drivers/leds/trigger/ledtrig-activity.c
> @@ -37,7 +37,6 @@ static void led_activity_function(struct timer_list *t)
> struct activity_data *activity_data = from_timer(activity_data, t,
> timer);
> struct led_classdev *led_cdev = activity_data->led_cdev;
> - struct timespec boot_time;
> unsigned int target;
> unsigned int usage;
> int delay;
> @@ -57,7 +56,7 @@ static void led_activity_function(struct timer_list *t)
> return;
> }
>
> - get_monotonic_boottime(&boot_time);
> + curr_boot = ktime_get_boot_ns();
>
> cpus = 0;
> curr_used = 0;
> @@ -76,7 +75,6 @@ static void led_activity_function(struct timer_list *t)
> * down to 16us, ensuring we won't overflow 32-bit computations below
> * even up to 3k CPUs, while keeping divides cheap on smaller systems.
> */
> - curr_boot = timespec_to_ns(&boot_time) * cpus;
Original code is pretty weird (notice the * cpus), so I'm
double-checking.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-06-18 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 14:41 [PATCH] leds: ledtrig-activity: use ktime_get_boot_ns() Arnd Bergmann
2018-06-18 15:07 ` Pavel Machek [this message]
2018-06-18 15:47 ` Arnd Bergmann
2018-06-18 15:55 ` Pavel Machek
2018-06-18 18:29 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618150715.GA30470@amd \
--to=pavel@ucw.cz \
--cc=arnd@arndb.de \
--cc=jacek.anaszewski@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=w@1wt.eu \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).