Re: [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral

kgunda
2018-07-23T06:16:19Z

On 2018-07-21 02:51, Pavel Machek wrote:
> Hi!
>
>> >@@ -332,6 +529,7 @@ static u32 wled_values(const struct wled_var_cfg *cfg, u32 idx)
>> > }
>> > #define WLED3 3
>> >+#define WLED4 4
>>
>> Are these macros always going to define 3 to be 3 and 4 to be 4. If so
>> we
>> probably don't need them (and they should be removed from patch 5/8
>> too).
>>
>> There is a degree of nitpicking here however. The rest looks OK to me.
>
> Really nitpicking, and I don't care much either way, but as natural
> numbering would be 0-based, I'd keep the defines.
> Pavel
Thanks Pavale/Daniel! I will remove the macros and use the number 3 and
4 instead.