From: Pavel Machek <pavel@ucw.cz>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
rteysseyre@gmail.com, Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 1/2] leds: core: Introduce LED pattern trigger
Date: Mon, 10 Sep 2018 23:20:51 +0200 [thread overview]
Message-ID: <20180910212051.GB4697@amd> (raw)
In-Reply-To: <CAMz4kuK=t9t0nZaVHguv_BVH5WKTDvxPrxCjPrpws9=VV_57ag@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
Hi!
> >> I'm still convinced that this will confuse our users and to me it would
> >> be more logical if this denotes the number of times the pattern should
> >> be repeated, with e.g. negative numbers denoting infinite.
> >
> > Sounds reasonable. Let's change this semantics as you propose.
> >
> >> In particular I expect to have to explain why my driver expects that you
> >> write 0 in the file named "repeat" to make it repeat and 1 to make it
> >> not repeat.
>
> Hm, so there are some cases we need to make clear.
> 1) If negative numbers present infinite, so what's the meaning of number 0?
> 2) What we should show for users if repeat number is negative, just
> show negative numbers or one string "infinite"?
I'd say just -1 is infinite, anything else is error.
And yes, reading it should just display -1.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-09-10 21:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 11:01 [PATCH v8 1/2] leds: core: Introduce LED pattern trigger Baolin Wang
2018-09-04 11:01 ` [PATCH v8 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller Baolin Wang
2018-09-04 20:19 ` Jacek Anaszewski
2018-09-05 2:43 ` Baolin Wang
2018-09-05 6:52 ` Baolin Wang
2018-09-08 5:02 ` [PATCH v8 1/2] leds: core: Introduce LED pattern trigger Bjorn Andersson
2018-09-08 20:19 ` Jacek Anaszewski
2018-09-09 13:38 ` Baolin Wang
2018-09-10 21:20 ` Pavel Machek [this message]
2018-09-11 1:22 ` Baolin Wang
2018-09-10 21:19 ` Pavel Machek
2018-09-11 18:43 ` Jacek Anaszewski
2018-09-12 19:18 ` Pavel Machek
2018-09-12 20:18 ` Jacek Anaszewski
2018-09-12 20:41 ` Pavel Machek
2018-09-13 19:37 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910212051.GB4697@amd \
--to=pavel@ucw.cz \
--cc=baolin.wang@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rteysseyre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).