From: Tony Lindgren <tony@atomide.com>
To: Dan Murphy <dmurphy@ti.com>
Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
lee.jones@linaro.org, linux-omap@vger.kernel.org,
linux-leds@vger.kernel.org, Milo Kim <milo.kim@ti.com>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Subject: Re: [RFC PATCH 1/9] leds: add TI LMU backlight driver
Date: Wed, 26 Sep 2018 08:01:45 -0700 [thread overview]
Message-ID: <20180926150145.GS5662@atomide.com> (raw)
In-Reply-To: <20180926130921.12329-2-dmurphy@ti.com>
* Dan Murphy <dmurphy@ti.com> [180926 13:14]:
> --- /dev/null
> +++ b/drivers/leds/ti-lmu-led-common.c
> +static int ti_lmu_common_enable(struct ti_lmu_bank *lmu_bank, bool enable)
> +{
> + struct regmap *regmap = lmu_bank->regmap;
> + unsigned long enable_time = lmu_bank->enable_usec;
> + u8 reg = lmu_bank->enable_reg;
> + u8 mask = BIT(lmu_bank->bank_id);
> + u8 val = (enable == true) ? mask : 0;
> + int ret;
> +
> + return 0;
Hmm this early return probably needs to be left out on real hardawre?
> + if (!reg)
> + return -EINVAL;
> +
> + ret = regmap_update_bits(regmap, reg, mask, val);
> + if (ret)
> + return ret;
> +
> + if (enable_time > 0)
> + usleep_range(enable_time, enable_time + 100);
> +
> + return 0;
> +}
Regards,
Tony
next prev parent reply other threads:[~2018-09-26 15:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 13:09 [RFC PATCH 0/9] TI LMU and Dedicated LED drivers Dan Murphy
2018-09-26 13:09 ` [RFC PATCH 1/9] leds: add TI LMU backlight driver Dan Murphy
2018-09-26 15:01 ` Tony Lindgren [this message]
2018-09-26 15:30 ` Dan Murphy
2018-09-26 13:09 ` [RFC PATCH 2/9] dt-bindings: ti-lmu: Remove LM3697 Dan Murphy
2018-09-26 13:09 ` [RFC PATCH 3/9] mfd: ti-lmu: Remove support for LM3697 Dan Murphy
2018-09-26 13:09 ` [RFC PATCH 4/9] dt-bindings: leds: Add bindings for lm3697 driver Dan Murphy
2018-09-26 13:09 ` [RFC PATCH 5/9] leds: lm3697: Introduce the " Dan Murphy
2018-09-26 13:09 ` [RFC PATCH 6/9] dt-bindings: leds: Add support for the LM3633 Dan Murphy
2018-09-26 13:09 ` [RFC PATCH 7/9] leds: lm3633: Introduce the lm3633 driver Dan Murphy
2018-09-26 22:36 ` Pavel Machek
2018-09-27 12:04 ` Dan Murphy
2018-09-27 21:47 ` Pavel Machek
2018-09-28 16:48 ` Dan Murphy
2018-09-26 13:09 ` [RFC PATCH 8/9] dt-bindings: leds: Add the LM3632 LED dt binding Dan Murphy
2018-09-26 13:09 ` [RFC PATCH 9/9] leds: lm3632: Introduce the TI LM3632 driver Dan Murphy
2018-10-07 13:46 ` Pavel Machek
2018-10-08 12:23 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926150145.GS5662@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).