From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Raphael Teysseyre <rteysseyre@gmail.com>,
Baolin Wang <baolin.wang@linaro.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org
Subject: [PATCH v5 0/5] leds: trigger: Add pattern initialization from Device Tree
Date: Tue, 1 Jan 2019 15:07:12 +0100 [thread overview]
Message-ID: <20190101140717.13564-1-krzk@kernel.org> (raw)
Hi,
Changes since v4:
1. Move helper to get default pattern from led-class.c to led-core.c and
rename it (build issue pointed by kbuild robot).
Changes since v3:
1. Add missing EXPORT_SYMBOL_GPL.
2. Put pattern trigger format into common file - shared between
dt-bindings and sysfs.
3. Use array of integers as led-pattern property (since it is bigger change
I did not add Pavel's ack to patch 2/5).
4. Mention ms units for led-pattern bindings.
Changes since v2:
1. Drop Jacek's patches and my "led: triggers: Initialize
LED_INIT_DEFAULT_TRIGGER if trigger is brought after class".
2. Follow Rob's advices about bindings - use "led-pattern" property
and generalize usage of it into to three triggers.
3. New patches (2/5, 4/5 and 5/5).
Changes since v1:
1. Rebase on Jacek's patches.
2. Add patch 3/5 for fixup of Jacek's solution.
3. Drop first two patches from the series (applied).
4. Patch 5/5: Use LED_INIT_DEFAULT_TRIGGER (suggested by Jacek Anaszewski).
5. Patch 5/5: Return-on-error and log warning (suggested by Pavel Machek).
Best regards,
Krzysztof
Krzysztof Kozlowski (5):
dt-bindings: leds: Add pattern initialization from Device Tree
leds: Add helper for getting default pattern from Device Tree
leds: trigger: pattern: Add pattern initialization from Device Tree
leds: trigger: oneshot: Add initialization from Device Tree
leds: trigger: timer: Add initialization from Device Tree
.../testing/sysfs-class-led-trigger-pattern | 51 +---------
.../devicetree/bindings/leds/common.txt | 12 +++
.../bindings/leds/leds-trigger-pattern.txt | 49 +++++++++
drivers/leds/led-core.c | 43 ++++++++
drivers/leds/trigger/ledtrig-oneshot.c | 38 ++++++-
drivers/leds/trigger/ledtrig-pattern.c | 99 +++++++++++++++----
drivers/leds/trigger/ledtrig-timer.c | 34 +++++++
include/linux/leds.h | 3 +
8 files changed, 260 insertions(+), 69 deletions(-)
create mode 100644 Documentation/devicetree/bindings/leds/leds-trigger-pattern.txt
--
2.17.1
next reply other threads:[~2019-01-01 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 14:07 Krzysztof Kozlowski [this message]
2019-01-01 14:07 ` [PATCH v5 1/5] dt-bindings: leds: Add pattern initialization from Device Tree Krzysztof Kozlowski
2019-01-01 14:07 ` [PATCH v5 2/5] leds: Add helper for getting default pattern " Krzysztof Kozlowski
2019-01-02 19:16 ` Jacek Anaszewski
2019-01-04 10:01 ` Krzysztof Kozlowski
2019-01-01 14:07 ` [PATCH v5 3/5] leds: trigger: pattern: Add pattern initialization " Krzysztof Kozlowski
2019-01-01 14:07 ` [PATCH v5 4/5] leds: trigger: oneshot: Add " Krzysztof Kozlowski
2019-01-01 14:07 ` [PATCH v5 5/5] leds: trigger: timer: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190101140717.13564-1-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rteysseyre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).