From: Anders Roxell <anders.roxell@linaro.org>
To: jacek.anaszewski@gmail.com, pavel@ucw.cz
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Anders Roxell <anders.roxell@linaro.org>
Subject: [PATCH] leds: lp55xx: fix warning unused label 'out'
Date: Thu, 14 Feb 2019 21:58:12 +0100 [thread overview]
Message-ID: <20190214205812.7311-1-anders.roxell@linaro.org> (raw)
When building leds lp55xx a waring about label 'out' defined but not used.
drivers/leds/leds-lp55xx-common.c: In function ‘lp55xx_firmware_loaded’:
drivers/leds/leds-lp55xx-common.c:217:1: warning: label ‘out’ defined but not used [-Wunused-label]
out:
^~~
Rework current code to remove the label 'out'.
905c2157dd19 ("leds: lp55xx: fix null deref on firmware load failure")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/leds/leds-lp55xx-common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c
index 64986f0fd367..723f2f17497a 100644
--- a/drivers/leds/leds-lp55xx-common.c
+++ b/drivers/leds/leds-lp55xx-common.c
@@ -214,7 +214,6 @@ static void lp55xx_firmware_loaded(const struct firmware *fw, void *context)
mutex_unlock(&chip->lock);
-out:
/* firmware should be released for other channel use */
release_firmware(chip->fw);
chip->fw = NULL;
--
2.19.2
reply other threads:[~2019-02-14 20:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214205812.7311-1-anders.roxell@linaro.org \
--to=anders.roxell@linaro.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).