linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: linux-leds@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	pavel@ucw.cz, robh@kernel.org, jacek.anaszewski@gmail.com,
	Dan Murphy <dmurphy@ti.com>
Subject: [PATCH v3 13/25] leds: lm3692x: Use generic support for composing LED names
Date: Sun, 31 Mar 2019 19:54:49 +0200	[thread overview]
Message-ID: <20190331175501.23471-14-jacek.anaszewski@gmail.com> (raw)
In-Reply-To: <20190331175501.23471-1-jacek.anaszewski@gmail.com>

Switch to using generic LED support for composing LED class
device name.

At this occassion remove initialization of struct led_classdev's
dev->of_node property in the driver, since now it will be taken from
fwnode assigned to struct led_init_data and passed to the new
devm_led_classdev_register_ext() API.

Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Dan Murphy <dmurphy@ti.com>
---
 drivers/leds/leds-lm3692x.c | 22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c
index 4f413a7c5f05..d2b30074d87a 100644
--- a/drivers/leds/leds-lm3692x.c
+++ b/drivers/leds/leds-lm3692x.c
@@ -13,7 +13,6 @@
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
 #include <linux/slab.h>
-#include <uapi/linux/uleds.h>
 
 #define LM36922_MODEL	0
 #define LM36923_MODEL	1
@@ -103,7 +102,6 @@
  * @regmap - Devices register map
  * @enable_gpio - VDDIO/EN gpio to enable communication interface
  * @regulator - LED supply regulator pointer
- * @label - LED label
  * @led_enable - LED sync to be enabled
  * @model_id - Current device model ID enumerated
  */
@@ -114,7 +112,6 @@ struct lm3692x_led {
 	struct regmap *regmap;
 	struct gpio_desc *enable_gpio;
 	struct regulator *regulator;
-	char label[LED_MAX_NAME_SIZE];
 	int led_enable;
 	int model_id;
 };
@@ -325,7 +322,7 @@ static int lm3692x_init(struct lm3692x_led *led)
 static int lm3692x_probe_dt(struct lm3692x_led *led)
 {
 	struct fwnode_handle *child = NULL;
-	const char *name;
+	struct led_init_data init_data;
 	int ret;
 
 	led->enable_gpio = devm_gpiod_get_optional(&led->client->dev,
@@ -350,30 +347,23 @@ static int lm3692x_probe_dt(struct lm3692x_led *led)
 	fwnode_property_read_string(child, "linux,default-trigger",
 				    &led->led_dev.default_trigger);
 
-	ret = fwnode_property_read_string(child, "label", &name);
-	if (ret)
-		snprintf(led->label, sizeof(led->label),
-			"%s::", led->client->name);
-	else
-		snprintf(led->label, sizeof(led->label),
-			 "%s:%s", led->client->name, name);
-
 	ret = fwnode_property_read_u32(child, "reg", &led->led_enable);
 	if (ret) {
 		dev_err(&led->client->dev, "reg DT property missing\n");
 		return ret;
 	}
 
-	led->led_dev.name = led->label;
+	init_data.fwnode = child;
+	init_data.led_hw_name = led->client->name;
+	init_data.default_label = ":";
 
-	ret = devm_led_classdev_register(&led->client->dev, &led->led_dev);
+	ret = devm_led_classdev_register_ext(&led->client->dev, &led->led_dev,
+					     &init_data);
 	if (ret) {
 		dev_err(&led->client->dev, "led register err: %d\n", ret);
 		return ret;
 	}
 
-	led->led_dev.dev->of_node = to_of_node(child);
-
 	return 0;
 }
 
-- 
2.11.0

  parent reply	other threads:[~2019-03-31 17:54 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-31 17:54 [PATCH v3 00/25] Add generic support for composing LED class device name Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 01/25] leds: class: Improve LED and LED flash class registration API Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 02/25] dt-bindings: leds: Add LED_FUNCTION definitions Jacek Anaszewski
2019-04-05  1:11   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 03/25] dt-bindings: leds: Add LED_COLOR_ID definitions Jacek Anaszewski
2019-04-05  1:12   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 04/25] dt-bindings: leds: Add function, color and led-enumerator properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 05/25] leds: core: Add support for composing LED class device names Jacek Anaszewski
2019-04-05 11:45   ` Dan Murphy
2019-04-05 20:08     ` Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 06/25] dt-bindings: sc27xx-blt: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 07/25] leds: sc27xx-blt: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 08/25] dt-bindings: lt3593: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 09/25] leds: lt3593: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 10/25] dt-bindings: lp8860: Add function and color properties Jacek Anaszewski
2019-04-05 11:47   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 11/25] leds: lp8860: Use generic support for composing LED names Jacek Anaszewski
2019-04-11 15:28   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 12/25] dt-bindings: lm3692x: Add function and color properties Jacek Anaszewski
2019-04-05 11:48   ` Dan Murphy
2019-03-31 17:54 ` Jacek Anaszewski [this message]
2019-04-11 15:29   ` [PATCH v3 13/25] leds: lm3692x: Use generic support for composing LED names Dan Murphy
2019-03-31 17:54 ` [PATCH v3 14/25] dt-bindings: lm36010: Add function and color properties Jacek Anaszewski
2019-04-05 11:48   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 15/25] leds: lm3601x: Use generic support for composing LED names Jacek Anaszewski
2019-04-11 15:29   ` Dan Murphy
2019-03-31 17:54 ` [PATCH v3 16/25] dt-bindings: cr0014114: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 17/25] leds: cr0014114: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 18/25] dt-bindings: aat1290: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 19/25] leds: aat1290: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 20/25] dt-bindings: as3645a: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 21/25] leds: as3645a: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 22/25] dt-bindings: leds-gpio: Add function and color properties Jacek Anaszewski
2019-03-31 17:54 ` [PATCH v3 23/25] leds: gpio: Use generic support for composing LED names Jacek Anaszewski
2019-03-31 17:55 ` [PATCH v3 24/25] dt-bindings: an30259a: Add function and color properties Jacek Anaszewski
2019-03-31 17:55 ` [PATCH v3 25/25] leds: an30259a: Use generic support for composing LED names Jacek Anaszewski
2019-04-04 13:21 ` [PATCH v3 00/25] Add generic support for composing LED class device name Pavel Machek
2019-04-04 19:18   ` Jacek Anaszewski
2019-04-06  9:46     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190331175501.23471-14-jacek.anaszewski@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).