From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com,
marek.behun@nic.cz, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [RFC PATCH 3/5] documention: leds: Add multicolor class documentation
Date: Mon, 1 Apr 2019 23:27:10 +0200 [thread overview]
Message-ID: <20190401212709.GA14681@amd> (raw)
In-Reply-To: <20190401173400.14238-4-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]
Hi!
> +Under the "colors" directory there are two files created "sync" and
> +"sync_enable". The sync_enable file controls whether the LED brightness
> +value is set real time or if the LED brightness value setting is deferred until
> +the "sync" file is written. If sync_enable is set then writing to each LED
> +"brightness" file will store the brightness value. Once the "sync" file is
> +written then each LED color defined in the node will write the brightness of
> +the LED in the device driver.
> +
> +If "sync_enable" is not set then writing the brightness value of the LED to the
> +device driver is done immediately. Writing the "sync" file has no
> affect.
I believe better solutions exists for this problem.
One was discussed before -- have single file which contains
coefficients for r/g/b channels.
Or at least... you should not really need separate sync and
sync_enable files. One should do.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-04-01 21:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 17:33 [RFC PATCH 0/5] MultiColor LED framework Documentation Dan Murphy
2019-04-01 17:33 ` [RFC PATCH 1/5] leds: multicolor: Add sysfs interface definition Dan Murphy
2019-04-01 17:33 ` [RFC PATCH 2/5] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-04-01 21:29 ` Pavel Machek
2019-04-02 11:40 ` Dan Murphy
2019-04-02 16:17 ` Marek Behun
2019-04-02 17:06 ` Dan Murphy
2019-04-02 20:40 ` Jacek Anaszewski
2019-04-02 19:51 ` Jacek Anaszewski
2019-04-01 17:33 ` [RFC PATCH 3/5] documention: leds: Add multicolor class documentation Dan Murphy
2019-04-01 21:18 ` Randy Dunlap
2019-04-01 21:27 ` Pavel Machek [this message]
2019-04-02 5:55 ` Marek Behun
2019-04-02 11:53 ` Dan Murphy
2019-04-02 15:56 ` Marek Behun
2019-04-01 17:33 ` [RFC PATCH 4/5] dt-bindings: leds: Add LED_COLOR_ID and COLOR_NAME definitions Dan Murphy
2019-04-01 17:34 ` [RFC PATCH 5/5] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-04-01 21:10 ` Randy Dunlap
2019-04-02 19:07 ` Dan Murphy
2019-04-02 5:44 ` Marek Behun
2019-04-02 11:55 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401212709.GA14681@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).