From: Pavel Machek <pavel@ucw.cz>
To: Nick Crews <ncrews@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com,
linux-kernel <linux-kernel@vger.kernel.org>,
Duncan Laurie <dlaurie@chromium.org>,
Daniel Erat <derat@google.com>, Guenter Roeck <groeck@google.com>,
Dmitry Torokhov <dtor@google.com>
Subject: Re: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support
Date: Thu, 4 Apr 2019 13:24:15 +0200 [thread overview]
Message-ID: <20190404112415.GB18653@amd> (raw)
In-Reply-To: <CAHX4x85=_76=Kyepf3Nw++4yVKOZujhLsonzaicZOnY5fi-Pfw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1546 bytes --]
On Mon 2019-03-11 09:29:06, Nick Crews wrote:
> Thanks for looking this over. I will fix most of your concerns, but
> have one question.
>
> On Fri, Mar 8, 2019 at 2:08 PM Pavel Machek <pavel@ucw.cz> wrote:
> >
> > On Fri 2019-03-08 13:38:02, Nick Crews wrote:
> > > This patch is meant to be applied on top of the for-next
> > > branch of the platform/chrome repository, as it uses some of
> > > the code staged there.
> > >
> > > The EC is in charge of controlling the keyboard backlight on
> > > the Wilco platform. We expose a standard LED class device at
> > > /sys/class/leds/wilco::kbd_backlight. This driver is modeled
> > > after the standard Chrome OS keyboard backlight driver at
> > > drivers/platform/chrome/cros_kbd_led_backlight.c
> >
> > Can you make it "platform::kbd_backlight"? We want some consistency
> > there.
>
> The analogous name in the standard driver
> drivers/platform/chrome/cros_kbd_led_backlight.c is
> "chromeos::kbd_backlight", and I thought "wilco" was a better
> substitute for "chromeos" than "platform" would be. What other thing
> are you saying "platform" would be consistent with?
Yeah, well, we not let the cros_kbd_led_backlight.c use chromeos:: in
the first place. But it happened. We want all backlights for the
system keyboard to use common name, and "chromeos" is not really
suitable for that. "platform" is.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-04-04 11:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 20:38 [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support Nick Crews
2019-03-08 21:08 ` Pavel Machek
2019-03-11 15:29 ` Nick Crews
2019-04-04 11:24 ` Pavel Machek [this message]
2019-04-04 14:11 ` Nick Crews
2019-04-04 16:13 ` Dmitry Torokhov
2019-04-04 19:03 ` Pavel Machek
2019-04-04 19:09 ` Dmitry Torokhov
2019-04-04 19:23 ` Pavel Machek
2019-04-04 20:07 ` Dmitry Torokhov
2019-04-04 20:11 ` Pavel Machek
2019-04-04 20:22 ` Dmitry Torokhov
2019-04-04 20:34 ` Pavel Machek
2019-03-08 22:01 ` Dmitry Torokhov
2019-03-08 22:13 ` Pavel Machek
2019-03-12 16:05 ` Nick Crews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404112415.GB18653@amd \
--to=pavel@ucw.cz \
--cc=bleung@chromium.org \
--cc=derat@google.com \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@google.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=ncrews@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).