From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name Date: Thu, 4 Apr 2019 20:59:19 +0200 Message-ID: <20190404185919.GB27340@amd> References: <20190404171007.160878-1-ncrews@chromium.org> <20190404171007.160878-3-ncrews@chromium.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DKU6Jbt7q3WqK7+M" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov Cc: Nick Crews , Guenter Roeck , Enric Balletbo i Serra , Benson Leung , linux-leds@vger.kernel.org, Jacek Anaszewski , Alexandre Belloni , Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel , Duncan Laurie , Simon Glass List-Id: linux-leds@vger.kernel.org --DKU6Jbt7q3WqK7+M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2019-04-04 11:55:27, Dmitry Torokhov wrote: > On Thu, Apr 4, 2019 at 11:41 AM Nick Crews wrote: > > > > On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > > > > > > On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck wro= te: > > > > > > > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews wr= ote: > > > > > > > > > > We want all backlights for the system keyboard to > > > > > use a common name, so the name "platform::kbd_backlight" > > > > > would be better than the current "chromeos::kbd_backlight" > > > > > name. Normally this wouldn't be worth changing, but the new > > > > > Wilco keyboard backlight driver uses the "platform" name. > > > > > We want to make it so all Chrome OS devices are consistent, > > > > > so we'll change the name here too. > > > > > > > > > > > > > Wondering - who is the "we" you are talking about ? > > > > You're right, I should have been more precise. > > I was referring to Pavel, Enric, and myself. Pavel had this opinion her= e: > > https://lkml.org/lkml/2019/4/4/1040. I don't know what Pavel meant by "= we" > > in that comment, but I would guess that could mean the other LED mainta= iners > > as well? I talked with Enric 1:1 and he didn't see the problem with cha= nging it, > > though perhaps he was only considering our use of the LED via powerd, > > and not users in general. I'm guessing Pavel's and Enric's meanings tho= ugh, > > excuse me if I am misinterpreting. > > > > > > > > This also has a potential of breaking existing setups if somebody did > > > happen to match on entire name instead of suffix. Such changes have to > > > be considered very carefully; at this point I am against of doing > > > this. > > > > Would it make sense to keep the old name as is, and only make the new > > Wilco name begin with "platform:"? What would you think is best? >=20 > Given that we do not have a single instance of platform::kbd_backlight > in kernel at this time I have no idea why Pavel is trying to push this > for Wilco driver. See the documentation in the email I sent few seconds ago. I hope it explains my reasoning, if not, I'll explain it. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --DKU6Jbt7q3WqK7+M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlymVAcACgkQMOfwapXb+vKuIgCfQ4vAKLf3CJRwuVbZyvRR1gjE /FEAoIV1bUD24tCqtjsj6OhV3dG0cvrF =SDUB -----END PGP SIGNATURE----- --DKU6Jbt7q3WqK7+M--