From: Pavel Machek <pavel@ucw.cz>
To: Dmitry Torokhov <dtor@google.com>
Cc: Nick Crews <ncrews@chromium.org>,
Guenter Roeck <groeck@google.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
linux-leds@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Duncan Laurie <dlaurie@chromium.org>,
Simon Glass <sjg@google.com>
Subject: Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name
Date: Thu, 4 Apr 2019 22:42:07 +0200 [thread overview]
Message-ID: <20190404204207.GH29984@amd> (raw)
In-Reply-To: <CAE_wzQ-8XwzptH7EqNrELxjBzY2+0oHJGB3Va=vZwwK3csu_aA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]
Hi!
> > > And what to do if internal keyboard is not platform but USB? Like
> > > Google "Whiskers"? (I am not sure why you decided to drop my mention
> > > of internal USB keyboards completely off your reply).
> >
> > I don't have answers for everything. Even if you have USB keyboard, you'll
> > likely still have backlight connected to embedded controller. If not,
> > then maybe you have exception userland needs to know about.
> >
> > Still better than making everything an exception.
>
> You do not need to make everything exception. You just need to look
> beyond the name, and see how the device is connected. And then apply
> your exceptions for "weird" devices.
"Where it is connected" is not interesting to the userland. "Is it
backlight for internal keyboard" is the right question. It may be
connected to embedded controller or some kind of controller over
i2c... my shell scripts should not need to know about architecture of
every notebook out there.
But I don't see why I should do additional work when its trivial for
kernel to just name the LED in an useful way.
"platform::kbd_backlight" has no disadvantages compared to
"wilco::kbd_backlight" ... so lets just use it.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-04-04 20:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 17:10 [PATCH v5 1/3] platform/chrome: wilco_ec: Standardize mailbox interface Nick Crews
2019-04-04 17:10 ` [PATCH v5 2/3] platform/chrome: Add Wilco EC keyboard backlight LEDs support Nick Crews
2019-04-04 19:52 ` Pavel Machek
2019-04-05 20:15 ` Guenter Roeck
2019-04-06 8:41 ` Pavel Machek
2019-04-07 21:46 ` Dmitry Torokhov
2019-04-07 22:18 ` Pavel Machek
2019-04-07 22:26 ` Dmitry Torokhov
2019-04-08 9:41 ` Keyboard backlight LED naming was " Pavel Machek
2019-04-08 13:31 ` Guenter Roeck
2019-04-04 17:10 ` [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name Nick Crews
2019-04-04 17:36 ` Guenter Roeck
2019-04-04 17:43 ` Dmitry Torokhov
2019-04-04 18:41 ` Nick Crews
2019-04-04 18:55 ` Dmitry Torokhov
2019-04-04 18:59 ` Pavel Machek
2019-04-04 19:05 ` Dmitry Torokhov
2019-04-04 19:19 ` Pavel Machek
2019-04-04 19:59 ` Dmitry Torokhov
2019-04-04 20:06 ` Pavel Machek
2019-04-04 20:13 ` Dmitry Torokhov
2019-04-04 20:20 ` Pavel Machek
2019-04-04 20:26 ` Dmitry Torokhov
2019-04-04 20:42 ` Pavel Machek [this message]
2019-04-04 21:48 ` Dmitry Torokhov
2019-04-04 22:05 ` Pavel Machek
2019-04-04 22:42 ` Guenter Roeck
2019-04-05 8:42 ` Enric Balletbo i Serra
2019-04-05 20:00 ` Jacek Anaszewski
2019-04-06 9:53 ` Pavel Machek
2019-04-06 14:15 ` Jacek Anaszewski
2019-04-06 22:17 ` Pavel Machek
2019-04-07 22:01 ` Dmitry Torokhov
2019-04-08 20:01 ` Jacek Anaszewski
2019-04-04 18:56 ` Pavel Machek
2019-04-08 23:58 ` Nick Crews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404204207.GH29984@amd \
--to=pavel@ucw.cz \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bleung@chromium.org \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@google.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=sjg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).