From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [GIT PULL v2] LM3532 backlight support improvements and relocation Date: Tue, 9 Apr 2019 07:56:49 -0700 Message-ID: <20190409145649.GE2839@atomide.com> References: <20190407190951.27288-1-jacek.anaszewski@gmail.com> <20190407221740.GA6327@amd> <20190408193055.GN49658@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dan Murphy Cc: Pavel Machek , Jacek Anaszewski , robh@kernel.org, lee.jones@linaro.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-leds@vger.kernel.org * Dan Murphy [190408 20:04]: > Tony > > On 4/8/19 2:30 PM, Tony Lindgren wrote: > > * Dan Murphy [190408 15:54]: > > > On 4/7/19 5:17 PM, Pavel Machek wrote: > > > > Plus, I'd kind of expect ALS enabled/disabled to be runtime controled, > > > > not from the device tree. > > > We can always add runtime override control to the driver. > > Yeah that sounds good to me :) Sounds like this can be done > > with follow up patches though. > > > > > Just need to see if there is a common interface from input or IIO we can adopt. > > Hmm can the lm3532 registers actually show the value > > for the ALS sensors? > > > No it can only report the current configured ALS zone not the LUX value. Sounds like it should be just enable/disable or auto/manual type toggle then in /sys somewhere for the users. Not sure if ledtrig-backlight-auto vs ledtrig-backlight would make sense? Regards, Tony