From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3 5/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697
Date: Wed, 1 May 2019 00:05:27 +0200 [thread overview]
Message-ID: <20190430220527.GC20410@amd> (raw)
In-Reply-To: <20190430191730.19450-6-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1991 bytes --]
On Tue 2019-04-30 14:17:28, Dan Murphy wrote:
> The LM3697 is a single function LED driver. The single function LED
> driver needs to reside in the LED directory as a dedicated LED driver
> and not as a MFD device. The device does have common brightness and ramp
> features and those can be accomodated by a TI LMU framework.
>
> The LM3697 dt binding needs to be moved from the ti-lmu.txt and a dedicated
> LED dt binding needs to be added. The new LM3697 LED dt binding will then
> reside in the Documentation/devicetree/bindings/leds directory and follow the
> current LED and general bindings guidelines.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v3 - No changes added Reviewed-by Rob - https://lore.kernel.org/patchwork/patch/1058762/
>
> v2 - Made changes to reference ti,brightness-resolution to the ti-lmu.txt -
> https://lore.kernel.org/patchwork/patch/1054501/
>
> .../devicetree/bindings/leds/leds-lm3697.txt | 73 +++++++++++++++++++
> .../devicetree/bindings/mfd/ti-lmu.txt | 27 +------
> 2 files changed, 74 insertions(+), 26 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3697.txt b/Documentation/devicetree/bindings/leds/leds-lm3697.txt
> new file mode 100644
> index 000000000000..02378f33c9ab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3697.txt
> @@ -0,0 +1,73 @@
> +* Texas Instruments - LM3697 Highly Efficient White LED Driver
> +
> +The LM3697 11-bit LED driver provides high-
> +performance backlight dimming for 1, 2, or 3 series
> +LED strings while delivering up to 90% efficiency.
> +
> +This device is suitable for display and keypad Lighting
"lightning."
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-04-30 22:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 19:17 [PATCH v3 0/7] LMU Common code intro Dan Murphy
2019-04-30 19:17 ` [PATCH v3 1/7] dt-bindings: mfd: LMU: Fix lm3632 dt binding example Dan Murphy
2019-04-30 19:17 ` [PATCH v3 2/7] dt-bindings: mfd: LMU: Add the ramp up/down property Dan Murphy
2019-04-30 22:01 ` Pavel Machek
2019-05-06 17:53 ` Dan Murphy
2019-04-30 19:17 ` [PATCH v3 3/7] dt-bindings: mfd: LMU: Add ti,brightness-resolution Dan Murphy
2019-04-30 19:17 ` [PATCH v3 4/7] leds: TI LMU: Add common code for TI LMU devices Dan Murphy
2019-04-30 19:23 ` Randy Dunlap
2019-04-30 19:30 ` Dan Murphy
2019-04-30 19:32 ` Jacek Anaszewski
2019-04-30 19:34 ` Dan Murphy
2019-04-30 19:17 ` [PATCH v3 5/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697 Dan Murphy
2019-04-30 22:05 ` Pavel Machek [this message]
2019-04-30 22:07 ` Dan Murphy
2019-04-30 22:08 ` Pavel Machek
2019-04-30 19:17 ` [PATCH v3 6/7] mfd: ti-lmu: Remove support for LM3697 Dan Murphy
2019-04-30 19:17 ` [PATCH v3 7/7] leds: lm3697: Introduce the lm3697 driver Dan Murphy
2019-04-30 22:05 ` [PATCH v3 0/7] LMU Common code intro Jacek Anaszewski
2019-05-01 9:45 ` Jacek Anaszewski
2019-05-08 6:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430220527.GC20410@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).