From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH] leds: avoid races with workqueue Date: Thu, 2 May 2019 21:13:22 +0200 Message-ID: <20190502191321.GB4845@amd> References: <20190426214246.GA24966@amd> <84fac57d-1121-a1da-fb45-16a2521bdef9@gmail.com> <20190427193411.GA9709@amd> <2578a614-beb9-1c9d-9f74-208a8a7ab64f@gmail.com> <20190427223207.GA3585@amd> <20190429152259.GB10501@amd> <36e1fdd7-a220-4b0d-d558-829f522b0841@gmail.com> <20190501183600.GA20452@amd> <9337b5fb-0ff8-9925-29e6-a781884af861@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7794894750878543199==" Return-path: In-Reply-To: <9337b5fb-0ff8-9925-29e6-a781884af861-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ibm-acpi-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jacek Anaszewski Cc: ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, ibm-acpi-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org, stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-leds@vger.kernel.org --===============7794894750878543199== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jho1yZJdad60DJr+" Content-Disposition: inline --jho1yZJdad60DJr+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>>+++ b/drivers/leds/led-class.c > >>>@@ -57,6 +57,7 @@ static ssize_t brightness_store(struct device *dev, > >>> if (state =3D=3D LED_OFF) > >>> led_trigger_remove(led_cdev); > >>> led_set_brightness(led_cdev, state); > >>>+ flush_work(&led_cdev->set_brightness_work); > >> > >>Is this really required here? It creates non-uniform brightness > >>setting behavior depending on whether it is set from sysfs or > >>by in-kernel call to led_set_brightness(). > > > >This fixes the echo 0 > brightness; echo 1 > brightness. It has to be > >at a place where we can sleep. > > > >If you have better idea, it is welcome, but it would be good to fix > >the bug. >=20 > Currently not, so I applied the patch in this shape. Thanks! This is actually something that makes sense for stable.. perhaps the bots can pick it up. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --jho1yZJdad60DJr+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzLQVEACgkQMOfwapXb+vKOoACfax+BPvnk0lcSUvQ9r9d9Osa5 c+EAnR0lfaZ44Vbj/bnmI3te1IvsqbU5 =p9ml -----END PGP SIGNATURE----- --jho1yZJdad60DJr+-- --===============7794894750878543199== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============7794894750878543199== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel --===============7794894750878543199==--