From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver Date: Thu, 30 May 2019 08:38:27 +0100 Message-ID: <20190530073827.GL4574@dell> References: <20190522192733.13422-1-dmurphy@ti.com> <20190522192733.13422-7-dmurphy@ti.com> <20190523125012.GB20354@amd> <0c2bd6af-92c5-2458-dc41-1ea413545347@ti.com> <89a80aa8-66ee-d0ec-fa54-c55ca8de06af@gmail.com> <20190529135821.GK4574@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jacek Anaszewski Cc: Dan Murphy , Pavel Machek , broonie@kernel.org, lgirdwood@gmail.com, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-leds@vger.kernel.org On Wed, 29 May 2019, Jacek Anaszewski wrote: > On 5/29/19 3:58 PM, Lee Jones wrote: > > On Fri, 24 May 2019, Jacek Anaszewski wrote: > > > > > Hi, > > > > > > On 5/23/19 9:09 PM, Dan Murphy wrote: > > > > Pavel > > > > > > > > Thanks for the review > > > > > > > > On 5/23/19 7:50 AM, Pavel Machek wrote: > > > > > Hi! > > > > > > > > > > > +++ b/drivers/leds/leds-lm36274.c > > > > > > > > > > > +static int lm36274_parse_dt(struct lm36274 *lm36274_data) > > > > > > +{ > > > > > > + struct fwnode_handle *child = NULL; > > > > > > + char label[LED_MAX_NAME_SIZE]; > > > > > > + struct device *dev = &lm36274_data->pdev->dev; > > > > > > + const char *name; > > > > > > + int child_cnt; > > > > > > + int ret = -EINVAL; > > > > > > + > > > > > > + /* There should only be 1 node */ > > > > > > + child_cnt = device_get_child_node_count(dev); > > > > > > + if (child_cnt != 1) > > > > > > + return ret; > > > > > > > > > > I'd do explicit "return -EINVAL" here. > > > > > > > > > > > > > ACK > > > > > > > > > > +static int lm36274_probe(struct platform_device *pdev) > > > > > > +{ > > > > > > + struct ti_lmu *lmu = dev_get_drvdata(pdev->dev.parent); > > > > > > + struct lm36274 *lm36274_data; > > > > > > + int ret; > > > > > > + > > > > > > + lm36274_data = devm_kzalloc(&pdev->dev, sizeof(*lm36274_data), > > > > > > + GFP_KERNEL); > > > > > > + if (!lm36274_data) { > > > > > > + ret = -ENOMEM; > > > > > > + return ret; > > > > > > + } > > > > > > > > > > And certainly do "return -ENOMEM" explicitly here. > > > > > > > > > > > > > ACK > > > > > > > > > Acked-by: Pavel Machek > > > > > > I've done all amendments requested by Pavel and updated branch > > > ib-leds-mfd-regulator on linux-leds.git, but in the same time > > > > What do you mean by updated? You cannot update an 'ib' (immutable > > branch). Immutable means that it cannot change, by definition. > > We have already talked about that. Nobody has pulled so the branch > could have been safely updated. You have no sure way to know that. And since I have no way to know, or faith that you won't update it again, pulling it now/at all would seem like a foolish thing to do. Until you can provide me with an assurance that you will not keep updating/changing the supposedly immutable pull-requests you send out, I won't be pulling any more in. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog