From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, broonie@kernel.org,
lgirdwood@gmail.com, lee.jones@linaro.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v6 4/5] dt-bindings: leds: Add LED bindings for the LM36274
Date: Thu, 6 Jun 2019 12:01:37 +0200 [thread overview]
Message-ID: <20190606100136.GF975@amd> (raw)
In-Reply-To: <20190605125634.7042-5-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]
Hi!
> .../devicetree/bindings/leds/leds-lm36274.txt | 82 +++++++++++++++++++
> 1 file changed, 82 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm36274.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm36274.txt b/Documentation/devicetree/bindings/leds/leds-lm36274.txt
> new file mode 100644
> index 000000000000..329393700191
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lm36274.txt
> @@ -0,0 +1,82 @@
> +* Texas Instruments LM36274 4-Channel LCD Backlight Driver w/Integrated Bias
> +
> +The LM36274 is an integrated four-channel WLED driver and LCD bias supply.
> +The backlight boost provides the power to bias four parallel LED strings with
> +up to 29V total output voltage. The 11-bit LED current is programmable via
> +the I2C bus and/or controlled via a logic level PWM input from 60 μA to 30 mA.
> +
> +Parent device properties are documented in ../mfd/ti_lmu.txt
> +Regulator properties are documented in ../regulator/lm363x-regulator.txt
Should these paths follow the same format as below
(Documentation/devicetree/bindings)
?
Otherwise looks good.
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-06-06 10:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 12:56 [PATCH v6 0/5] LM36274 Introduction Dan Murphy
2019-06-05 12:56 ` [PATCH v6 1/5] dt-bindings: mfd: Add lm36274 bindings to ti-lmu Dan Murphy
2019-06-05 12:56 ` [PATCH v6 2/5] mfd: ti-lmu: Add LM36274 support to the ti-lmu Dan Murphy
2019-06-06 9:52 ` Pavel Machek
2019-06-05 12:56 ` [PATCH v6 3/5] regulator: lm363x: Add support for LM36274 Dan Murphy
2019-06-05 18:17 ` Mark Brown
2019-06-06 9:53 ` Pavel Machek
2019-06-05 12:56 ` [PATCH v6 4/5] dt-bindings: leds: Add LED bindings for the LM36274 Dan Murphy
2019-06-06 10:01 ` Pavel Machek [this message]
2019-06-05 12:56 ` [PATCH v6 5/5] leds: lm36274: Introduce the TI LM36274 LED driver Dan Murphy
2019-06-06 10:07 ` Pavel Machek
2019-06-06 10:07 ` Pavel Machek
2019-06-06 11:25 ` Dan Murphy
2019-06-05 19:31 ` [PATCH v6 0/5] LM36274 Introduction Jacek Anaszewski
2019-06-11 12:17 ` Dan Murphy
2019-06-24 14:42 ` Lee Jones
2019-06-24 17:20 ` Dan Murphy
2019-06-25 6:30 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606100136.GF975@amd \
--to=pavel@ucw.cz \
--cc=broonie@kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).