From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/34] leds: leds-pca955x: simplify getting the adapter of a client
Date: Sun, 9 Jun 2019 13:05:20 +0200 [thread overview]
Message-ID: <20190609110519.GA2375@amd> (raw)
In-Reply-To: <e5a91999-a156-77b2-702b-8931140f0f8d@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]
On Sun 2019-06-09 13:03:40, Jacek Anaszewski wrote:
> Hi Wolfram,
>
> Thank you for the patches.
>
> On 6/8/19 12:55 PM, Wolfram Sang wrote:
> >We have a dedicated pointer for that, so use it. Much easier to read and
> >less computation involved.
> >
> >Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >---
> >
> >Please apply to your subsystem tree.
> >
> > drivers/leds/leds-pca955x.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
> >index a9f5dad55956..460626d81c6a 100644
> >--- a/drivers/leds/leds-pca955x.c
> >+++ b/drivers/leds/leds-pca955x.c
> >@@ -432,7 +432,7 @@ static int pca955x_probe(struct i2c_client *client,
> > int ngpios = 0;
> > chip = &pca955x_chipdefs[id->driver_data];
> >- adapter = to_i2c_adapter(client->dev.parent);
> >+ adapter = client->adapter;
> > pdata = dev_get_platdata(&client->dev);
> > if (!pdata) {
> > pdata = pca955x_get_pdata(client, chip);
> >
>
> For both 4/34 and 5/34:
>
> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
4 and 5:
Acked-by: Pavel Machek <pavel@ucw.cz>
But I wonder if it should go through the leds tree?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-06-09 11:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 10:55 [PATCH 00/34] treewide: simplify getting the adapter of an I2C client Wolfram Sang
2019-06-08 10:55 ` [PATCH 04/34] leds: leds-pca955x: simplify getting the adapter of a client Wolfram Sang
2019-06-09 11:03 ` Jacek Anaszewski
2019-06-09 11:05 ` Pavel Machek [this message]
2019-06-09 11:17 ` Jacek Anaszewski
2019-06-08 10:55 ` [PATCH 05/34] leds: leds-tca6507: " Wolfram Sang
2019-06-13 9:47 ` Simon Horman
2019-06-09 16:37 ` [PATCH 00/34] treewide: simplify getting the adapter of an I2C client Peter Rosin
2019-06-10 7:15 ` Wolfram Sang
2019-06-27 18:28 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190609110519.GA2375@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).