From: Nishka Dasgupta <nishkadg.linux@gmail.com>
To: bgolaszewski@baylibre.com, jacek.anaszewski@gmail.com,
pavel@ucw.cz, dmurphy@ti.com, linux-leds@vger.kernel.org
Cc: Nishka Dasgupta <nishkadg.linux@gmail.com>
Subject: [PATCH] leds: leds-max77650: Add of_node_put() before return
Date: Tue, 9 Jul 2019 23:05:09 +0530 [thread overview]
Message-ID: <20190709173509.14016-1-nishkadg.linux@gmail.com> (raw)
Each iteration of for_each_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return in five places.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
drivers/leds/leds-max77650.c | 20 +++++++++++++++-----
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/drivers/leds/leds-max77650.c b/drivers/leds/leds-max77650.c
index 6b74ce9cac12..417820f77c32 100644
--- a/drivers/leds/leds-max77650.c
+++ b/drivers/leds/leds-max77650.c
@@ -93,8 +93,10 @@ static int max77650_led_probe(struct platform_device *pdev)
for_each_child_of_node(of_node, child) {
rv = of_property_read_u32(child, "reg", ®);
- if (rv || reg >= MAX77650_LED_NUM_LEDS)
+ if (rv || reg >= MAX77650_LED_NUM_LEDS) {
+ of_node_put(child);
return -EINVAL;
+ }
led = &leds[reg];
led->map = map;
@@ -109,24 +111,32 @@ static int max77650_led_probe(struct platform_device *pdev)
} else {
led->cdev.name = devm_kasprintf(dev, GFP_KERNEL,
"max77650:%s", label);
- if (!led->cdev.name)
+ if (!led->cdev.name) {
+ of_node_put(child);
return -ENOMEM;
+ }
}
of_property_read_string(child, "linux,default-trigger",
&led->cdev.default_trigger);
rv = devm_of_led_classdev_register(dev, child, &led->cdev);
- if (rv)
+ if (rv) {
+ of_node_put(child);
return rv;
+ }
rv = regmap_write(map, led->regA, MAX77650_LED_A_DEFAULT);
- if (rv)
+ if (rv) {
+ of_node_put(child);
return rv;
+ }
rv = regmap_write(map, led->regB, MAX77650_LED_B_DEFAULT);
- if (rv)
+ if (rv) {
+ of_node_put(child);
return rv;
+ }
}
return regmap_write(map,
--
2.19.1
next reply other threads:[~2019-07-09 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 17:35 Nishka Dasgupta [this message]
2019-07-11 7:10 ` [PATCH] leds: leds-max77650: Add of_node_put() before return Bartosz Golaszewski
2019-07-11 7:31 ` Nishka Dasgupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709173509.14016-1-nishkadg.linux@gmail.com \
--to=nishkadg.linux@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).