From: Pavel Machek <pavel@ucw.cz>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Matthias Kaehlcke <mka@chromium.org>,
jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,
dmurphy@ti.com, "David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v6 4/4] net: phy: realtek: Add LED configuration support for RTL8211E
Date: Mon, 7 Oct 2019 13:02:39 +0200 [thread overview]
Message-ID: <20191007110239.GA21484@amd> (raw)
In-Reply-To: <20190819003757.GB8981@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
On Mon 2019-08-19 02:37:57, Andrew Lunn wrote:
> > Yes, I believe the integration is neccessary. Using same binding is
> > neccessary for that, but not sufficient. For example, we need
> > compatible trigger names, too.
>
> Hi Pavel
>
> Please could you explain what you mean by compatible trigger names?
Well, you attempted to put trigger names in device tree. That means
those names should work w.r.t. LED subsystem, too.
> > So... I'd really like to see proper integration is possible before we
> > merge this.
>
> Please let me turn that around. What do you see as being impossible at
> the moment? What do we need to convince you about?
That locking requirements are compatible, that triggers you invented
can be implemented by LED subsystem, ...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2019-10-07 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190813191147.19936-1-mka@chromium.org>
[not found] ` <20190813191147.19936-5-mka@chromium.org>
[not found] ` <20190816201342.GB1646@bug>
[not found] ` <20190816212728.GW250418@google.com>
2019-08-17 14:05 ` [PATCH v6 4/4] net: phy: realtek: Add LED configuration support for RTL8211E Pavel Machek
2019-08-19 0:37 ` Andrew Lunn
2019-10-07 11:02 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007110239.GA21484@amd \
--to=pavel@ucw.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).