Re: [PATCH v11 01/16] dt: bindings: Add multicolor class dt bindings documention

Dan Murphy
2019-10-10T00:49:40Z

Jacek

On 10/9/19 5:07 PM, Jacek Anaszewski wrote:
> Dan,
>
> On 10/8/19 10:47 PM, Dan Murphy wrote:
>> Add DT bindings for the LEDs multicolor class framework.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>> .../bindings/leds/leds-class-multicolor.txt | 98 +++++++++++++++++++
>> 1 file changed, 98 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.txt b/Documentation/devicetree/bindings/leds/leds-class-multicolor.txt
>> new file mode 100644
>> index 000000000000..8619c9bf1811
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.txt
>> @@ -0,0 +1,98 @@
>> +* Multicolor LED properties
>> +
>> +Bindings for multi color LEDs show how to describe current outputs of
>> +either integrated multi-color LED elements (like RGB, RGBW, RGBWA-UV
>> +etc.) or standalone LEDs, to achieve logically grouped multi-color LED
>> +modules. This is achieved by adding multi-led nodes layer to the
>> +monochrome LED bindings.
>> +
>> +The nodes and properties defined in this document are unique to the multicolor
>> +LED class. Common LED nodes and properties are inherited from the common.txt
>> +within this documentation directory.
>> +
>> +Required LED Child properties:
> s/Child/child/

Ack

>
>> + - color : For multicolor LED support this property should be defined as
>> + LED_COLOR_ID_MULTI and further definition can be found in
>> + include/linux/leds/common.h.
>> +
>> +led-controller@30 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "ti,lp5024";
>> + reg = <0x29>;
>> +
>> + multi-led@1 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <1>;
>> + color = <LED_COLOR_ID_MULTI>;
>> + function = LED_FUNCTION_STATUS;
> Status is not too fancy function for multi color LED ;-)
> I'd skip it entirely for this example if we don't have
> anything suitable at the moment for our disposal.

Not sure I understand.  Status is a good example as a RGB module can be
used to present charging status

Unless I misinterpreted your comment.

Dan