From: Sasha Levin <sashal@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Martin Schiller <ms@dev.tdt.de>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.4 034/134] leds: trigger: netdev: fix handling on interface rename
Date: Sat, 14 Dec 2019 13:11:37 -0500 [thread overview]
Message-ID: <20191214181137.GH12996@sasha-vm> (raw)
In-Reply-To: <20191214084331.GD16834@duo.ucw.cz>
On Sat, Dec 14, 2019 at 09:43:31AM +0100, Pavel Machek wrote:
>On Wed 2019-12-11 10:10:10, Sasha Levin wrote:
>> From: Martin Schiller <ms@dev.tdt.de>
>>
>> [ Upstream commit 5f820ed52371b4f5d8c43c93f03408d0dbc01e5b ]
>>
>> The NETDEV_CHANGENAME code is not "unneeded" like it is stated in commit
>> 4cb6560514fa ("leds: trigger: netdev: fix refcnt leak on interface
>> rename").
>>
>> The event was accidentally misinterpreted equivalent to
>> NETDEV_UNREGISTER, but should be equivalent to NETDEV_REGISTER.
>>
>> This was the case in the original code from the openwrt project.
>>
>> Otherwise, you are unable to set netdev led triggers for (non-existent)
>> netdevices, which has to be renamed. This is the case, for example, for
>> ppp interfaces in openwrt.
>
>Please drop.
Here's a bug report from a user (fixed by this patch):
https://forum.openwrt.org/t/18-06-4-serious-led-problems-td-w8970-v1/40417
He has titled the report "18.06.4:Serious ‘LED’ Problems!", and in the
bug report itself he has mentioned:
The LED's are really important to me. please let me know how to
fix this by my self! I cannot report it and wait for next few
months for patch, again!
There are two other similar bug reports:
https://bugs.openwrt.org/index.php?do=details&task_id=2193
https://bugs.openwrt.org/index.php?do=details&task_id=2239
So this is obviously an issue that affects users and needs to be fixed.
Beyond the above, the patch is upstream, it fixes a single issue, and is
shorter than 100 lines.
I'm going to go ahead and ignore your input for this and the rest of the
led patches in the series for similar reasons.
--
Thanks,
Sasha
prev parent reply other threads:[~2019-12-14 18:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191211151150.19073-1-sashal@kernel.org>
2019-12-11 15:10 ` [PATCH AUTOSEL 5.4 032/134] leds: lm3692x: Handle failure to probe the regulator Sasha Levin
2019-12-14 8:42 ` Pavel Machek
2019-12-11 15:10 ` [PATCH AUTOSEL 5.4 033/134] leds: an30259a: add a check for devm_regmap_init_i2c Sasha Levin
2019-12-14 8:42 ` Pavel Machek
2019-12-11 15:10 ` [PATCH AUTOSEL 5.4 034/134] leds: trigger: netdev: fix handling on interface rename Sasha Levin
2019-12-14 8:43 ` Pavel Machek
2019-12-14 18:11 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191214181137.GH12996@sasha-vm \
--to=sashal@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=pavel@ucw.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox