From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0112C10F28 for ; Sun, 8 Mar 2020 21:47:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 776B320684 for ; Sun, 8 Mar 2020 21:47:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Xc45nRq6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726397AbgCHVrx (ORCPT ); Sun, 8 Mar 2020 17:47:53 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:54703 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726359AbgCHVrw (ORCPT ); Sun, 8 Mar 2020 17:47:52 -0400 Received: by mail-pj1-f65.google.com with SMTP id np16so3466761pjb.4 for ; Sun, 08 Mar 2020 14:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jJDC8Nnm4L4CGbPKhZAhNhjZs4K9A5jkhmw2WKtbXvE=; b=Xc45nRq6+6S+BPEEpPP+4qYsrd/yLeFpPUjzp8hif0jnk5SK49WpGYuBAmRbn5IrpE a3APlX9HUnDyjhdWOR+9dneLxP3Kw+sXYF8aBmBpjElev2SHOMCC3XtbyyT6epEwQ9/e +KPJHUHbaUWnoMg/a6cRtamWF4U0Y+p59eKVoyPKUmAdn3FEo/8WoIrWt3WUb1ih6+UN Wl2LScuXMfAtXgDDG2kZQVo6qVyGEHkxHOb/nV/XnBLlhD2KWTEcGSZX8CjaY3JnunZf XZfO4xWhHNWiTbygLclPt5EP4sd6NgnCtl5WUY5/sbBr0YT+VEJGD0t8asF5od1cLT03 iOhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jJDC8Nnm4L4CGbPKhZAhNhjZs4K9A5jkhmw2WKtbXvE=; b=CcTi+rmqx/e9bnt4lxJoGCM2IeA/XBGA902JLWweeh6SVrxK7jUG3/1F+SfiRYvuPy yc+AFuJ/cL4lx0Kv9ol0Btk01rcKbSW1FP5r0Kq1yhmZMim1Rddek7msG7bvHNwB4auT bJJBA73xVWUMPniFpRuAOThGndYFvjnXJGh4gkhEzfvenjbB6qkqvHn4RHhPko3ML96R hHgXPGyXF5EmnIbbuguMtdctcwcdWle1x/QC5rJxEBJLs+pZE6JHnfyvEqoGbAoWER5U x0M1V4tlVPaM+1qkO+oFYDvkCkeaS6cDecZ0zZ/vObLVZTGXqtf9QI3P6hAC0OQtwRxB OHjQ== X-Gm-Message-State: ANhLgQ1Gw1kLgtpQV75qIZGar82sWByVf+jsEV1PDDxpZzM3EwdJqlNM pNjQtgYtWuZYV/dlHwk2d26dmEbxejs= X-Google-Smtp-Source: ADFU+vssZQKZgUsi3zvBuFMQX3Exk1+IvjMjEEbarnjChBfU1sfwU0TO1HyH9F9S3DHVljCer4MCDw== X-Received: by 2002:a17:90a:8983:: with SMTP id v3mr15069544pjn.65.1583704071686; Sun, 08 Mar 2020 14:47:51 -0700 (PDT) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id d186sm24369069pfc.8.2020.03.08.14.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2020 14:47:50 -0700 (PDT) Date: Sun, 8 Mar 2020 14:47:48 -0700 From: Bjorn Andersson To: Kiran Gunda Cc: jingoohan1@gmail.com, lee.jones@linaro.org, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, daniel.thompson@linaro.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Murphy , Andy Gross , linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH V1 2/2] backlight: qcom-wled: Add support for WLED5 peripheral in PM8150L Message-ID: <20200308214748.GL1094083@builder> References: <1583153739-19170-1-git-send-email-kgunda@codeaurora.org> <1583153739-19170-3-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1583153739-19170-3-git-send-email-kgunda@codeaurora.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Mon 02 Mar 04:55 PST 2020, Kiran Gunda wrote: > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c [..] > @@ -147,14 +187,39 @@ struct wled { > u32 max_brightness; > u32 short_count; > u32 auto_detect_count; > + u32 version; > bool disabled_by_short; > bool has_short_detect; > + bool cabc_disabled; > int short_irq; > int ovp_irq; > > struct wled_config cfg; > struct delayed_work ovp_work; > int (*wled_set_brightness)(struct wled *wled, u16 brightness); > + int (*cabc_config)(struct wled *wled, bool enable); > + int (*wled_sync_toggle)(struct wled *wled); Please split this patch in one that adds these and breaks out the wled3 support, and then a second patch that adds wled5. > +}; > + [..] > +static int wled5_set_brightness(struct wled *wled, u16 brightness) > +{ > + int rc, offset; > + u16 low_limit = wled->max_brightness * 1 / 1000; > + u8 v[2], brightness_msb_mask; > + > + /* WLED5's lower limit is 0.1% */ > + if (brightness > 0 && brightness < low_limit) > + brightness = low_limit; > + > + brightness_msb_mask = 0xf; > + if (wled->max_brightness == WLED5_SINK_REG_BRIGHT_MAX_15B) > + brightness_msb_mask = 0x7f; Why not just brightness &= wled->max_brightness? But given that it seems like the framework ensures that brightness <= max_brightness, why not skip this altogether? > + > + v[0] = brightness & 0xff; > + v[1] = (brightness >> 8) & brightness_msb_mask; > + > + offset = wled5_brightness_reg[wled->cfg.mod_sel]; > + rc = regmap_bulk_write(wled->regmap, wled->sink_addr + offset, > + v, 2); > + return rc; > +} > + > static int wled4_set_brightness(struct wled *wled, u16 brightness) > { > int rc, i; > @@ -237,7 +325,28 @@ static int wled_module_enable(struct wled *wled, int val) > return 0; > } > > -static int wled_sync_toggle(struct wled *wled) > +static int wled5_sync_toggle(struct wled *wled) > +{ > + int rc; > + u8 val; > + > + val = (wled->cfg.mod_sel == MOD_A) ? WLED5_SINK_REG_SYNC_MOD_A_BIT : > + WLED5_SINK_REG_SYNC_MOD_B_BIT; > + rc = regmap_update_bits(wled->regmap, > + wled->sink_addr + WLED5_SINK_REG_MOD_SYNC_BIT, > + WLED5_SINK_REG_SYNC_MASK, val); > + if (rc < 0) > + return rc; > + > + val = 0; Just plug 0 in the function call. > + rc = regmap_update_bits(wled->regmap, > + wled->sink_addr + WLED5_SINK_REG_MOD_SYNC_BIT, > + WLED5_SINK_REG_SYNC_MASK, val); > + > + return rc; And return regmap_update_bits(...); > +} > + Regards, Bjorn