From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA7AC4332B for ; Sat, 21 Mar 2020 20:44:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C492D206F9 for ; Sat, 21 Mar 2020 20:44:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="lQWIk/Kr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726846AbgCUUow (ORCPT ); Sat, 21 Mar 2020 16:44:52 -0400 Received: from lists.nic.cz ([217.31.204.67]:47340 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbgCUUow (ORCPT ); Sat, 21 Mar 2020 16:44:52 -0400 Received: from localhost (unknown [172.20.6.135]) by mail.nic.cz (Postfix) with ESMTPSA id 77B911431A0; Sat, 21 Mar 2020 21:44:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1584823490; bh=HchH2kOUuqIIPLGTJXda0/kWOWMKymuoFlHjkoLXDAI=; h=Date:From:To; b=lQWIk/KrEApHYirwsYpYn2z5DHif/Jg9vlNqeDhV7IL+ePpWejqcbxBEOElUWMEea 088/P0wMrBD6/GrdiSnH+E/6d8q5DGc6/0LZWc0SDzLR79Nw83ycE1gL7Z1vjEhhwu /ecmFWEpcSshUtkUMlaaumvIHQcME6rQb+ZnvjzA= Date: Sat, 21 Mar 2020 21:44:49 +0100 From: Marek Behun To: Jacek Anaszewski Cc: linux-leds@vger.kernel.org, Pavel Machek Subject: Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs Message-ID: <20200321214449.0564a524@nic.cz> In-Reply-To: <0279d61f-6366-02cf-3d65-93d76e52de93@gmail.com> References: <20200319181604.2425-1-marek.behun@nic.cz> <0279d61f-6366-02cf-3d65-93d76e52de93@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.101.4 at mail X-Virus-Status: Clean Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Sat, 21 Mar 2020 19:55:15 +0100 Jacek Anaszewski wrote: > What is the rationale behind setting all LEDs to max_brighntess > on driver removal? > For each RGB LED the microcontroller has ON/OFF setting, and color setting. When in HW triggering mode, the HW triggering manipulates the ON/OFF setting and the LED blinks with the color set by the color setting. If I did not set color to white before driver removal, then the HW triggering would blink the LEDs with the color they had set by the user. That could be [0,0,0], so the LEDs wouldn't blink at all. So on driver removal the LEDs are set into state in which they are after reset.