From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25CBEC4332D for ; Sat, 21 Mar 2020 21:53:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B820920754 for ; Sat, 21 Mar 2020 21:53:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="JCdN2XpL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726755AbgCUVxo (ORCPT ); Sat, 21 Mar 2020 17:53:44 -0400 Received: from mail.nic.cz ([217.31.204.67]:43052 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbgCUVxo (ORCPT ); Sat, 21 Mar 2020 17:53:44 -0400 Received: from localhost (unknown [172.20.6.135]) by mail.nic.cz (Postfix) with ESMTPSA id 895361431A9; Sat, 21 Mar 2020 22:53:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1584827622; bh=xrWbLm8pqBpcCrukx5+5WlnMKdfw7XJ0kSCwn7K4C9g=; h=Date:From:To; b=JCdN2XpLAz1Qw7JfQETz+Istz8W3tYlCp+qzMu6fmLgr/uQhDcmqYbfDzcbmM3hUy H3/WNYm9JKQXo87Qi9/bukHn7SjsC6PPCP1Hr5XL3CkF4+XVVP1oHBuSzAq+MCo+9M NvPisukyvs8GRrqBoQUeuGij22I0IrJ5rzzZajmA= Date: Sat, 21 Mar 2020 22:53:42 +0100 From: Marek Behun To: linux-leds@vger.kernel.org Cc: Jacek Anaszewski , Pavel Machek Subject: Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs Message-ID: <20200321225342.7651547b@nic.cz> In-Reply-To: <20200319181604.2425-1-marek.behun@nic.cz> References: <20200319181604.2425-1-marek.behun@nic.cz> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.101.4 at mail X-Virus-Status: Clean Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hmm. The microcontroller on Turris Omnia supports more settings than just LEDs (usb3 port power and input button for example). I am wondering if this approach (registering LED driver to communicate with the microcontroller) is correct, since the microcontroller can do other things. For Turris Mox firmware I created a driver in drivers/firmware/turris-mox-rwtm.c. Maybe I should create I driver in drivers/firmware/ for the Omnia microcontroller, and then the LED driver could use functions exported by the microcontroller driver to manipulate LEDs. What do you think? Marek