Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs

Pavel Machek
2020-03-21T22:16:56Z

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

Hi!

> The microcontroller on Turris Omnia supports more settings than just
> LEDs (usb3 port power and input button for example).
>
> I am wondering if this approach (registering LED driver to
> communicate with the microcontroller) is correct, since the
> microcontroller can do other things.
>
> For Turris Mox firmware I created a driver in
> drivers/firmware/turris-mox-rwtm.c.

this should be drivers/platform/turris/, I believe. It is not
_firmware_, is it?

> Maybe I should create I driver in drivers/firmware/ for the Omnia
> microcontroller, and then the LED driver could use functions exported
> by the microcontroller driver to manipulate LEDs.
>
> What do you think?

So... you can do that, but you'll have multiple maintainers
coordinating updates at that point. Feel free to split LED support
into two files so that it can be moved to different directory later...

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]