Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs

Pavel Machek
2020-03-21T15:34:47Z

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

Hi!

> + if (led->color != color) {
> + dev_warn(dev, "Node %pfw: 'color' should be %s!\n", node,
> + led_colors[color]);
> + return 0;
> + }
> +
> + init_data.devicename = "omnia";
> + init_data.fwnode = node;
> + init_data.devname_mandatory = true;

How will this look in the /sys/class/leds?

We don't want to see omnia:xxx:xx there. For the ethernet activity
leds, it would be nice to get something like eth0:red:activity...?

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]