Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs

Jacek Anaszewski
2020-03-22T15:28:48Z

Hi Marek,

On 3/21/20 9:44 PM, Marek Behun wrote:
> On Sat, 21 Mar 2020 19:55:15 +0100
> Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:
>
>> What is the rationale behind setting all LEDs to max_brighntess
>> on driver removal?
>>
>
> For each RGB LED the microcontroller has ON/OFF setting, and color
> setting. When in HW triggering mode, the HW triggering manipulates the
> ON/OFF setting and the LED blinks with the color set by the color
> setting.
>
> If I did not set color to white before driver removal, then the HW
> triggering would blink the LEDs with the color they had set by the
> user. That could be [0,0,0], so the LEDs wouldn't blink at all.
>
> So on driver removal the LEDs are set into state in which they are after
> reset.

Sounds reasonable, ack.

--
Best regards,
Jacek Anaszewski