Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs

Pavel Machek
2020-04-06T08:34:26Z

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

On Sun 2020-03-22 16:51:02, Jacek Anaszewski wrote:
> Marek,
>
> On 3/21/20 9:50 PM, Marek Behun wrote:
> > On Sat, 21 Mar 2020 19:01:15 +0100
> > Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:
> >
> >>> How will this look in the /sys/class/leds?
> >>>
> >>> We don't want to see omnia:xxx:xx there. For the ethernet activity
> >>> leds, it would be nice to get something like eth0:red:activity...?
> >>
> >> devicename and devicename_mandatory should be removed.
> >>
> >
> > Without this I have:
> >
> > omnialeds /sys/class/leds # ls
> > blue:power red:power white:lan-2 white:pci-1 white:user-1
> > green:power white:lan-0 white:lan-3 white:pci-2 white:user-2
> > mmc0:: white:lan-1 white:lan-4 white:pci-3 white:wan
>
> You might want to associate the LED with actual eth interface,
> as Pavel mentioned, but that would require some more work.

Yes please.

> Anyway, "omnia" alone doesn't allow to tell the location of the
> LED either.

ACK.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]