Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs

Jacek Anaszewski
2020-03-29T12:54:02Z

Hi Marek,

On 3/28/20 6:20 PM, Marek Behun wrote:
> On Sat, 28 Mar 2020 14:01:47 +0100
> Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:
>
>> I already proposed adding a "luma" LED class device for similar
>> case [0], but didn't here any feedback from Pavel so far.
>>
>> [0]
>> https://lore.kernel.org/linux-leds/1583502010-16210-1-git-send-email-nbelin@baylibre.com/T/#mf52c8d4f68260a445223c26957c61e6267e0932d
>>
>
> Hi Jacek,
>
> in the case you mentioned there is a one "global" brightness setting per
> each RGB LED. On Omnia, all 12 RGB LEDs have just one "global"
> brightness property. Ie. I press the button, and all 12 LEDs glow get
> dimmer. So there could be a 13th LED device with color LUMA, but what
> function should it be given in DTS?

Then, in this particular case, adding devicename prefix for the whole
family of LEDs would be justified. The question is whether it should be
hardware related name or rather something different.

--
Best regards,
Jacek Anaszewski