Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs

Dan Murphy
2020-03-22T15:56:31Z

Marek

On 3/21/20 5:36 PM, Marek Behun wrote:
> On Sat, 21 Mar 2020 23:16:53 +0100
> Pavel Machek <pavel@ucw.cz> wrote:
>
>> Hi!
>>
>>> The microcontroller on Turris Omnia supports more settings than just
>>> LEDs (usb3 port power and input button for example).
>>>
>>> I am wondering if this approach (registering LED driver to
>>> communicate with the microcontroller) is correct, since the
>>> microcontroller can do other things.
>>>
>>> For Turris Mox firmware I created a driver in
>>> drivers/firmware/turris-mox-rwtm.c.
>> this should be drivers/platform/turris/, I believe. It is not
>> _firmware_, is it?
>>
> It is code that interacts with the firmware. It already is merged in
> drivers/firmware/. The raspberrypi firmware interacting drivers is also
> there...

Would a MFD driver be better here?

Dan