Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs

Jacek Anaszewski
2020-03-21T18:01:21Z

On 3/21/20 4:34 PM, Pavel Machek wrote:
> Hi!
>
>> + if (led->color != color) {
>> + dev_warn(dev, "Node %pfw: 'color' should be %s!\n", node,
>> + led_colors[color]);
>> + return 0;
>> + }
>> +
>> + init_data.devicename = "omnia";
>> + init_data.fwnode = node;
>> + init_data.devname_mandatory = true;
>
> How will this look in the /sys/class/leds?
>
> We don't want to see omnia:xxx:xx there. For the ethernet activity
> leds, it would be nice to get something like eth0:red:activity...?

devicename and devicename_mandatory should be removed.

--
Best regards,
Jacek Anaszewski