Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs

Jacek Anaszewski
2020-03-22T15:51:07Z

Marek,

On 3/21/20 9:50 PM, Marek Behun wrote:
> On Sat, 21 Mar 2020 19:01:15 +0100
> Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:
>
>>> How will this look in the /sys/class/leds?
>>>
>>> We don't want to see omnia:xxx:xx there. For the ethernet activity
>>> leds, it would be nice to get something like eth0:red:activity...?
>>
>> devicename and devicename_mandatory should be removed.
>>
>
> Without this I have:
>
> omnialeds /sys/class/leds # ls
> blue:power red:power white:lan-2 white:pci-1 white:user-1
> green:power white:lan-0 white:lan-3 white:pci-2 white:user-2
> mmc0:: white:lan-1 white:lan-4 white:pci-3 white:wan

You might want to associate the LED with actual eth interface,
as Pavel mentioned, but that would require some more work.

Anyway, "omnia" alone doesn't allow to tell the location of the
LED either.

--
Best regards,
Jacek Anaszewski