Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs

Pavel Machek
2020-04-06T21:10:06Z

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

Hi!

> >>> so now we have
> >>> device:color:function
> >>> what if we made it so that there was a 4th part of LED name, ie
> >>> group:device:color:function
> >>> ?
> >>>
> >>> Would this be a problem?
> >>
> >> Indeed, the device alone would not be a sufficient differentiator
> >> since it is possible to have more than one LED controller of the
> >> same type on the board.
> >>
> >> Nonetheless, I'd rather avoid the addition of a new generic section.
> >> Probably we would have to make it specific to this device.
> >>
> >
> > Ok, in that case I will do it so that devicename is "omnia".
> > devicename_mandatory should be set to true, yes?
>
> If you want to have four sections then you must compose LED
> name yourself and not use new *ext() API. But please hold on,
> since I suppose Pavel will have something to add to that.

Lets just handle global brightness outside LED subsystem.

And drop the omnia: .. it is useless. For some of your leds it should
be "ethX:...:activity".

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]