From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=6Q9a=5S=vger.kernel.org=linux-leds-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id EE028C43331
	for <linux-leds@archiver.kernel.org>; Thu,  2 Apr 2020 14:29:53 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 8C0EC2073B
	for <linux-leds@archiver.kernel.org>; Thu,  2 Apr 2020 14:29:53 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="NEIC1vNa"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732302AbgDBO3x (ORCPT <rfc822;linux-leds@archiver.kernel.org>);
        Thu, 2 Apr 2020 10:29:53 -0400
Received: from lists.nic.cz ([217.31.204.67]:40608 "EHLO mail.nic.cz"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1732261AbgDBO3x (ORCPT <rfc822;linux-leds@vger.kernel.org>);
        Thu, 2 Apr 2020 10:29:53 -0400
Received: from localhost (unknown [172.20.6.135])
        by mail.nic.cz (Postfix) with ESMTPSA id D0DFB141340;
        Thu,  2 Apr 2020 16:29:51 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default;
        t=1585837791; bh=XUS8x6NN+UFSzgUKCNWhkZ78ofMbehY3V8C69smTyL0=;
        h=Date:From:To;
        b=NEIC1vNaXN31G1ynl0QQ9UbuzlZKyoOA/TXNg/SGhqJ5BSXEANWpGrKeXmoCDRvIh
         /D6itNKnyvvGPF2l/WtAyNM73tPjb15buP6wptqV1V5iZ4tBwlQQdFKp2OMag4M58k
         4SgEN3uS90JX5+jrlPK/sWiengrodEF9hZ3QHciA=
Date:   Thu, 2 Apr 2020 16:29:50 +0200
From:   Marek Behun <marek.behun@nic.cz>
To:     Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc:     Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org
Subject: Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia
 LEDs
Message-ID: <20200402162950.5c2847be@nic.cz>
In-Reply-To: <7a12c510-605c-b31f-79e6-cccf3e29c682@gmail.com>
References: <20200319181604.2425-1-marek.behun@nic.cz>
        <20200321153325.GD8386@duo.ucw.cz>
        <943a5770-ea9c-24ac-5ab3-a9a24fc6a856@gmail.com>
        <20200328132729.5e628fe6@nic.cz>
        <20200328133629.79603fe3@nic.cz>
        <00b6737b-47f8-7ea4-74b7-eee3d2aefdf3@gmail.com>
        <20200328182025.0b33200e@nic.cz>
        <7a12c510-605c-b31f-79e6-cccf3e29c682@gmail.com>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: clamav-milter 0.101.4 at mail
X-Virus-Status: Clean
Sender: linux-leds-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-leds.vger.kernel.org>
X-Mailing-List: linux-leds@vger.kernel.org

On Sun, 29 Mar 2020 14:53:57 +0200
Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:

> > in the case you mentioned there is a one "global" brightness setting per
> > each RGB LED. On Omnia, all 12 RGB LEDs have just one "global"
> > brightness property. Ie. I press the button, and all 12 LEDs glow get
> > dimmer. So there could be a 13th LED device with color LUMA, but what
> > function should it be given in DTS?  
> 
> Then, in this particular case, adding devicename prefix for the whole
> family of LEDs would be justified. The question is whether it should be
> hardware related name or rather something different.

Hi Jacek,

so now we have
  device:color:function
what if we made it so that there was a 4th part of LED name, ie
  group:device:color:function
?

Would this be a problem?

Marek