Re: [PATCH v26 03/15] leds: multicolor: Introduce a multicolor class definition

Jacek Anaszewski
2020-06-06T19:59:45Z

Dan,

On 6/6/20 6:39 PM, Dan Murphy wrote:
> Pavek
>
> Thanks for the review
>
> On 6/6/20 10:53 AM, Pavel Machek wrote:
>> Hi!
>>
>>> Introduce a multicolor class that groups colored LEDs
>>> within a LED node.
>>>
>>> The multi color class groups monochrome LEDs and allows controlling two
>>> aspects of the final combined color: hue and lightness. The former is
>>> controlled via the intensity file and the latter is controlled
>>> via brightness file.
>>>
>>> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>> diff --git a/Documentation/ABI/testing/sysfs-class-led-multicolor
>>> b/Documentation/ABI/testing/sysfs-class-led-multicolor
>>> new file mode 100644
[...]
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -9533,6 +9533,14 @@ F:    Documentation/devicetree/bindings/leds/
>>>   F:    drivers/leds/
>>>   F:    include/linux/leds.h
>>> +LED MULTICOLOR FRAMEWORK
>>> +M:    Dan Murphy <dmurphy@ti.com>
>>> +L:    linux-leds@vger.kernel.org
>> I'd like to be mentioned here, too. "M: Pavel Machek
>> <pavel@ucw.cz>". And I'm not sure if I should be taking MAINTAINER
>> file update through a LED tree. Should definitely go to separate
>> patch.
>
> Oh definitely.  I thought it was implied that you and Jacek are both
> Maintainers as well.
>
> I will add you but will wait to see if Jacek wants to be added.

Actually I don't think that we need to add this separate entry
for LED multicolor class. This is still under LED subsystem,
and I didn't add anything for LED class flash.

> I will separate this out and make it a separate patch

--
Best regards,
Jacek Anaszewski