From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07BF4C433E0 for ; Wed, 22 Jul 2020 10:34:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D63E52065E for ; Wed, 22 Jul 2020 10:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731610AbgGVKef (ORCPT ); Wed, 22 Jul 2020 06:34:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726153AbgGVKef (ORCPT ); Wed, 22 Jul 2020 06:34:35 -0400 Received: from mail.nic.cz (lists.nic.cz [IPv6:2001:1488:800:400::400]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EED5C0619DC for ; Wed, 22 Jul 2020 03:34:35 -0700 (PDT) Received: from localhost (unknown [IPv6:2a0e:b107:ae1:0:3e97:eff:fe61:c680]) by mail.nic.cz (Postfix) with ESMTPSA id E2359140527; Wed, 22 Jul 2020 12:34:31 +0200 (CEST) Date: Wed, 22 Jul 2020 12:34:31 +0200 From: Marek Behun To: Pavel Machek Cc: linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com, Dan Murphy Subject: Re: [PATCH v6 2/3] leds: initial support for Turris Omnia LEDs Message-ID: <20200722123431.46b95739@nic.cz> In-Reply-To: <20200722071542.GB8984@amd> References: <20200721125922.10979-1-marek.behun@nic.cz> <20200721125922.10979-3-marek.behun@nic.cz> <20200722071542.GB8984@amd> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Wed, 22 Jul 2020 09:15:42 +0200 Pavel Machek wrote: > Hi! > > > + > > +/* > > + * On the front panel of the Turris Omnia router there is also a button which can be used to control > > + * the intensity of all the LEDs at once, so that if they are too bright, user can dim them. > > + * The microcontroller cycles between 8 levels of this global brightness (from 100% to 0%), but this > > + * setting can have any integer value between 0 and 100. It is therefore convenient to be able to > > + * change this setting from software. > > + * We expose this setting via a sysfs attribute file called "brightness". This file lives in the > > + * device directory of the LED controller, not an individual LED, so it should not confuse users. > > + */ > > Lets keep comments formatted to 80 columns. This overflew my screen > and is unreadable. > Pavel OK. But you are aware that default limit was increased to 100 columns, right? Marek