From: Pavel Machek <pavel@ucw.cz>
To: truart@gmx.de
Cc: linux-leds@vger.kernel.org
Subject: Re: led block trigger patch
Date: Mon, 10 Aug 2020 09:33:59 +0200 [thread overview]
Message-ID: <20200810073359.GA15023@amd> (raw)
In-Reply-To: <trinity-bc8857f4-cee1-4b95-a4fd-cc817119a95c-1597042087357@3c-app-gmx-bap76>
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
Hi!
> > Find out what is wrong with the patch, fix it, resubmit it.
>
> I would like to, but unfortunately, I've no skills in programming so I'm not able to do that.
>
You can learn, or find someone to do the work for you.
What was the point of me reviewing the old patch when you are not
going to fix it? That was not very constructive.
> > Oh. It appears to register trigger per block device. That's no-no.
>
> Hmm, why is that a no-no? It seems it works that way for CPUs already. I can see triggers from cpu0 to cpu39 on our servers with two CPUs, 10 cores and 2 threads per core. So we even have one trigger for every cpu thread.
>
> I've never seen a host with 40 nvme disks, so why is this problematic if having 40 cpu triggers is not? Or does "trigger per block device" mean sth. else?
We made a mistake with cpu triggers. Not doing it again.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-08-10 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 18:47 led block trigger patch truart
2020-08-05 21:57 ` Pavel Machek
[not found] ` <50db75e2-d53c-ce8b-bd00-1099be0e2e74@ifi.lmu.de>
2020-08-10 6:48 ` truart
2020-08-10 7:33 ` Pavel Machek [this message]
2020-08-10 7:53 ` Aw: " truart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810073359.GA15023@amd \
--to=pavel@ucw.cz \
--cc=linux-leds@vger.kernel.org \
--cc=truart@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).