led block trigger patch

led block trigger patch

[truart]

Hej hej,

I already asked on the linux-block list, but that was likely the wrong place, so I try here.

All our new thinkpads are missing a hard disk led, and when trying to use some keyboard led it turned out that this is not really working. The LED is either just blinking or showing nothing. When googling we found https://www.spinics.net/lists/linux-scsi/msg132286.html
All the laptops have nvme disks, so this is exactly what we need. But it seems to be missing in the latest kernel.

So may I ask what happened to this patch? Is it scheduled for being added? It's definitely needed as every new notebook I'm aware of doesn't have hard disk leds while nvme disks are default for most new notebooks now. So linux should be able to show disk traffic not only for ide and sata but also for up-to-date disk technologies. Any chance we get that patch? Is there a place to vote for a patch?

Thanks!
Michael

Re: led block trigger patch

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

On Tue 2020-07-28 20:47:32, truart@gmx.de wrote:
> Hej hej,
> 
> I already asked on the linux-block list, but that was likely the wrong place, so I try here.
> 
> All our new thinkpads are missing a hard disk led, and when trying to use some keyboard led it turned out that this is not really working. The LED is either just blinking or showing nothing. When googling we found https://www.spinics.net/lists/linux-scsi/msg132286.html
> All the laptops have nvme disks, so this is exactly what we need. But it seems to be missing in the latest kernel.
>

> So may I ask what happened to this patch? Is it scheduled for being added? It's definitely needed as every new notebook I'm aware of doesn't have hard disk leds while nvme disks are default for most new notebooks now. So linux should be able to show disk traffic not only for ide and sata but also for up-to-date disk technologies. Any chance we get that patch? Is there a place to vote for a patch?
> 

Not scheduled. And we don't do voting.

Find out what is wrong with the patch, fix it, resubmit it.

Oh. It appears to register trigger per block device. That's no-no.

Are you willing to seriously work on that?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: led block trigger patch

[truart]

Pavel Machek wrote:

> Find out what is wrong with the patch, fix it, resubmit it.

I would like to, but unfortunately, I've no skills in programming so I'm not able to do that.

> Oh. It appears to register trigger per block device. That's no-no.

Hmm, why is that a no-no? It seems it works that way for CPUs already. I can see triggers from cpu0 to cpu39 on our servers with two CPUs, 10 cores and 2 threads per core. So we even have one trigger for every cpu thread.

I've never seen a host with 40 nvme disks, so why is this problematic if having 40 cpu triggers is not? Or does "trigger per block device" mean sth. else?

Michael

Re: led block trigger patch

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

Hi!

> > Find out what is wrong with the patch, fix it, resubmit it.
> 
> I would like to, but unfortunately, I've no skills in programming so I'm not able to do that.
> 

You can learn, or find someone to do the work for you.

What was the point of me reviewing the old patch when you are not
going to fix it? That was not very constructive.

> > Oh. It appears to register trigger per block device. That's no-no.
> 
> Hmm, why is that a no-no? It seems it works that way for CPUs already. I can see triggers from cpu0 to cpu39 on our servers with two CPUs, 10 cores and 2 threads per core. So we even have one trigger for every cpu thread.
> 
> I've never seen a host with 40 nvme disks, so why is this problematic if having 40 cpu triggers is not? Or does "trigger per block device" mean sth. else?

We made a mistake with cpu triggers. Not doing it again. 

								Pavel
								
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Aw: Re: led block trigger patch

[truart]

> What was the point of me reviewing the old patch when you are not
> going to fix it? That was not very constructive.

I'm sorry :( I really didn't mean to cause unneccessary work for anyone!
Michael