linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "xing.zhang" <xing.zhang@mediatek.com>
Cc: Luotao Fu <l.fu@pengutronix.de>,
	"; Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
	linux-leds@vger.kernel.org
Subject: Re: leds-pwm  driver further requirement discussion
Date: Sun, 16 Aug 2020 22:41:18 +0200	[thread overview]
Message-ID: <20200816204118.GA1481@bug> (raw)
In-Reply-To: <1597377070.2687.35.camel@mbjsdccf07>

Hi!

>     We have used leds-pwm driver to control led in some mediatek IC, but
> we have some further requirement, and want to add some common functions
> for this driver, could you give us some suggestions?
>     For dts, we want to add led-bits and trans-bits, led-bits represents
> the led bits(8->255, 10->1023) from user space, trans-bits represents
> the led hardware IC bits.

First, please make sure there is no existing functionality that can be used. If not, please
use something like "max brightness", not bits.

>     For function, we want to add led event notify, one event is for led
> brightness change, the other one is for led shutdown.
>     We also want to add setMaxBrightness function and setLedBrightness
> function for other module to call.

Umm. No?

Best regards,

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

           reply	other threads:[~2020-08-16 20:41 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1597377070.2687.35.camel@mbjsdccf07>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200816204118.GA1481@bug \
    --to=pavel@ucw.cz \
    --cc=jacek.anaszewski@gmail.com \
    --cc=l.fu@pengutronix.de \
    --cc=linux-leds@vger.kernel.org \
    --cc=xing.zhang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).