From: Andrew Lunn <andrew@lunn.ch>
To: Luka Kovacic <luka.kovacic@sartura.hr>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org,
lee.jones@linaro.org, pavel@ucw.cz, dmurphy@ti.com,
robh+dt@kernel.org, jdelvare@suse.com, linux@roeck-us.net,
jason@lakedaemon.net, gregory.clement@bootlin.com,
luka.perkov@sartura.hr
Subject: Re: [PATCH 7/7] arm64: dts: marvell: Add a device tree for the iEi Puzzle-M801 board
Date: Sat, 5 Sep 2020 17:21:22 +0200 [thread overview]
Message-ID: <20200905152122.GB3164319@lunn.ch> (raw)
In-Reply-To: <20200905130336.967622-8-luka.kovacic@sartura.hr>
On Sat, Sep 05, 2020 at 03:03:36PM +0200, Luka Kovacic wrote:
> +&cp0_mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + status = "okay";
> +
> + ge_phy2: ethernet-phy@2 {
> + reg = <0>;
Hi Luka
The value after the @ should be the same as the reg value.
So this should be ge_phy2: ethernet-phy@0
> + };
> +
> + ge_phy3: ethernet-phy@3 {
> + reg = <1>;
And this is:
ge_phy2: ethernet-phy@1
This is a general DT rule, so please check the whole file.
> +&cp0_eth0 {
> + status = "okay";
> + phy-mode = "10gbase-r";
> + phys = <&cp0_comphy4 0>;
> + local-mac-address = [00 50 43 de ff 00];
Does the bootloader overwrite these with per device MAC addresses?
Looking up this OUI i find:
00:50:43 Marvell Semiconductor, Inc.
I'm not sure you should be using that!
Andrew
prev parent reply other threads:[~2020-09-05 15:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 13:03 [PATCH 0/7] Add support for the iEi Puzzle-M801 board Luka Kovacic
2020-09-05 13:03 ` [PATCH 1/7] dt-bindings: Add iEi vendor prefix and iEi WT61P803 PUZZLE driver bindings Luka Kovacic
2020-09-05 13:03 ` [PATCH 2/7] drivers: mfd: Add a driver for iEi WT61P803 PUZZLE MCU Luka Kovacic
2020-09-05 15:39 ` Randy Dunlap
2020-09-09 9:40 ` Lee Jones
2020-09-05 13:03 ` [PATCH 3/7] drivers: hwmon: Add the iEi WT61P803 PUZZLE HWMON driver Luka Kovacic
2020-09-05 15:24 ` Guenter Roeck
2020-09-05 13:03 ` [PATCH 4/7] drivers: leds: Add the iEi WT61P803 PUZZLE LED driver Luka Kovacic
2020-09-08 22:22 ` Pavel Machek
2020-09-09 9:30 ` Andy Shevchenko
2020-09-09 10:36 ` Pavel Machek
2020-09-09 12:46 ` Andrew Lunn
2020-09-09 13:52 ` Andy Shevchenko
2020-09-09 18:34 ` Luka Kovačič
2020-09-05 13:03 ` [PATCH 5/7] Documentation/ABI: Add iei-wt61p803-puzzle driver sysfs interface documentation Luka Kovacic
2020-09-05 13:03 ` [PATCH 6/7] MAINTAINERS: Add an entry for the iEi WT61P803 PUZZLE driver Luka Kovacic
2020-09-05 13:03 ` [PATCH 7/7] arm64: dts: marvell: Add a device tree for the iEi Puzzle-M801 board Luka Kovacic
2020-09-05 15:21 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200905152122.GB3164319@lunn.ch \
--to=andrew@lunn.ch \
--cc=dmurphy@ti.com \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luka.kovacic@sartura.hr \
--cc=luka.perkov@sartura.hr \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox