From: Marek Behun <marek.behun@nic.cz>
To: "Adrian Schmutzler" <mail@adrianschmutzler.de>
Cc: "'Pavel Machek'" <pavel@ucw.cz>, <linux-leds@vger.kernel.org>
Subject: Re: How to name multiple LEDs of the same type and color
Date: Mon, 21 Sep 2020 03:00:44 +0200 [thread overview]
Message-ID: <20200921030044.304f0d5c@nic.cz> (raw)
In-Reply-To: <00f701d68fa6$2778ce60$766a6b20$@adrianschmutzler.de>
On Mon, 21 Sep 2020 01:31:23 +0200
"Adrian Schmutzler" <mail@adrianschmutzler.de> wrote:
> > > link3 {
> > > function = LED_FUNCTION_RSSI;
> > > color = <LED_COLOR_ID_GREEN>;
> > > gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
> > > };
> > > };
> > Well, this is not really three LEDs. This is more like... LED meter
> > composed of three LEDs. And we don't have good support for that.
> > But I guess we'll need it one day. There were some previous attempts:
> > https://lwn.net/Articles/802967/
> > Do you plan to control RSSI LEDs from kernel?
>
> To be honest, I mostly sent this patch for completeness.
>
> OpenWrt uses a very simple process written in C for updating these LEDs, which is quite old and has essentially remained unchanged for years, but does its job.
> I personally don't think there will be overwhelming interest in touching this and migrate it to whatever different implementation without a pressing need.
>
> My main interest here was/is that I started to evaluate how OpenWrt can migrate from LED labels to the "new" color/function syntax and to me the rssi leds are a dedicated type that should be supported.
> So I fear I won't be helpful for the implementation of RSSI leds in the kernel in general.
>
> For the three leds vs. set of leds discussion: Note that we are interested in (and already do) exposing each LED to the user individually (in user-space via sysfs), so the user can redefine the purpose of the LED freely based on his/her desire. Therefore, a total abstraction of the set of LEDs as a single entity would be detrimental for us here.
>
> Best
>
> Adrian
This is interesting. How does this work? Better signal => faster
blinking?
Where is the signal strength taken from?
Marek
next prev parent reply other threads:[~2020-09-21 1:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 21:21 How to name multiple LEDs of the same type and color Adrian Schmutzler
2020-09-20 1:17 ` Marek Behun
2020-09-20 11:08 ` Pavel Machek
2020-09-20 23:31 ` Adrian Schmutzler
2020-09-21 1:00 ` Marek Behun [this message]
2020-09-21 8:31 ` Pavel Machek
2020-09-21 9:49 ` Adrian Schmutzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921030044.304f0d5c@nic.cz \
--to=marek.behun@nic.cz \
--cc=linux-leds@vger.kernel.org \
--cc=mail@adrianschmutzler.de \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox