From: Marek Behun <marek.behun@nic.cz>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org, Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH leds v3 6/9] leds: lm36274: use devres LED registering function
Date: Tue, 22 Sep 2020 18:58:40 +0200 [thread overview]
Message-ID: <20200922185840.61396186@nic.cz> (raw)
In-Reply-To: <20200922163842.GB25550@duo.ucw.cz>
On Tue, 22 Sep 2020 18:38:42 +0200
Pavel Machek <pavel@ucw.cz> wrote:
> On Sun 2020-09-20 23:54:36, Marek Behun wrote:
> > On Sun, 20 Sep 2020 23:45:32 +0200
> > Pavel Machek <pavel@ucw.cz> wrote:
> >
> > > Hi!
> > >
> > > > Now that the potential use-after-free issue is resolved we can use
> > > > devres for LED registration in this driver.
> > > >
> > > > By using devres version of LED registering function we can remove the
> > > > .remove method from this driver.
> > > >
> > > > Signed-off-by: Marek Behún <marek.behun@nic.cz>
> > > > Cc: Dan Murphy <dmurphy@ti.com>
> > >
> > > AFAICT this one is buggy, I sent explanation before. Why are you
> > > resubmitting it?
> >
> > The previous patch in this series (v3 5/9) should solve this issue and
> > th commit message explains how.
>
> Aha, let me see.
>
> Will 5/9 have some side-effects, like device appearing at different
> place in sysfs?
Yes, unfortunately. Before this path the led should be in
/sys/devices/.../i2c-client/leds/led
or somthing like that, and after
/sys/devices/..c/i2c-client/mfd/leds/led
But it should have been this way from beginning, I think. The other
driver, regulator, registers its device under the mfd device.
The question is whether this will break something for someone. I don't
think so, but...
>
> First few patches look ok, but it would be really nice someone tested
> complete sereies.
>
> Best regards,
> Pavel
next prev parent reply other threads:[~2020-09-22 16:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 18:02 [PATCH leds v3 0/9] Start moving parsing of `linux,default-trigger` to LED core (a cleanup of LED drivers) Marek Behún
2020-09-19 18:02 ` [PATCH leds v3 1/9] leds: lm36274: cosmetic: rename lm36274_data to chip Marek Behún
2020-09-22 15:39 ` Dan Murphy
2020-09-22 16:32 ` Pavel Machek
2020-09-19 18:02 ` [PATCH leds v3 2/9] leds: lm36274: don't iterate through children since there is only one Marek Behún
2020-09-22 15:42 ` Dan Murphy
2020-09-22 15:58 ` Marek Behun
2020-09-22 19:12 ` Dan Murphy
2020-09-19 18:02 ` [PATCH leds v3 3/9] leds: lm36274: use struct led_init_data when registering Marek Behún
2020-09-24 12:06 ` Pavel Machek
2020-09-19 18:02 ` [PATCH leds v3 4/9] leds: lm36274: do not set chip settings in DT parsing function Marek Behún
2020-09-19 18:03 ` [PATCH leds v3 5/9] leds: lm36274: use platform device as parent of LED Marek Behún
2020-09-19 18:03 ` [PATCH leds v3 6/9] leds: lm36274: use devres LED registering function Marek Behún
2020-09-20 21:45 ` Pavel Machek
2020-09-20 21:54 ` Marek Behun
2020-09-22 16:38 ` Pavel Machek
2020-09-22 16:58 ` Marek Behun [this message]
2020-09-22 19:09 ` Dan Murphy
2020-09-19 18:03 ` [PATCH leds v3 7/9] leds: lm3532: don't parse label DT property Marek Behún
2020-09-19 18:03 ` [PATCH leds v3 8/9] leds: syscon: use struct led_init_data when registering Marek Behún
2020-09-29 13:17 ` Linus Walleij
2020-09-19 18:03 ` [PATCH leds v3 9/9] leds: parse linux,default-trigger DT property in LED core Marek Behún
2020-09-24 12:10 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922185840.61396186@nic.cz \
--to=marek.behun@nic.cz \
--cc=dmurphy@ti.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox