Re: [PATCH v5 1/3] leds: pwm: Remove platform_data support

Pavel Machek
2020-09-30T17:24:48Z

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

Hi!

> > > +__attribute__((nonnull))
> > >
> > > static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
> > >
> > > struct led_pwm *led, struct fwnode_handle *fwnode)
> > >
> > > {
> >
> > This normally goes elsewhere -- right? I'd expect:
> >
> >
> > static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
> > struct led_pwm *led, struct fwnode_handle *fwnode)
> > __attribute__((nonnull))
>
> I found both variants in kernel code. I can live with both variants and have
> no strong preference.
>
> My initial intention to add it was to get a compiler warning in case someone
> does not pass a fwnode here, e.g. when using that old platform_data approach
> (which is supposed to be removed with this patch). You might call it a self
> check on my own changes. I can also drop that attribute if you don't want
> that kind of stuff in linux-leds.

I'm okay with it at the second place :-).

Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]