From: "Marek Behún" <kabel@kernel.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Ben Whitten <ben.whitten@gmail.com>,
linux-leds@vger.kernel.org
Subject: Re: ledtrig netdev: what is the purpose of spinlock usage?
Date: Fri, 30 Oct 2020 00:14:45 +0100 [thread overview]
Message-ID: <20201030001445.40154b4a@kernel.org> (raw)
In-Reply-To: <984dfc46-f9a0-fb6e-0eef-3837e3fec0b7@gmail.com>
On Thu, 29 Oct 2020 23:49:19 +0100
Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:
> register_netdevice_notifier() registers raw notifier chain,
> whose callbacks are not called from atomic context and there are
> no restrictions on callbacks. See include/linux/notifier.h.
>
> So it looks like the spin_lock_bh() can be safely changed to
> mutex_lock().
>
Niiiiceeee, this simplifies things much. Thank you, Jacek :)
prev parent reply other threads:[~2020-10-29 23:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 6:00 ledtrig netdev: what is the purpose of spinlock usage? Marek Behún
2020-10-29 17:45 ` Pavel Machek
2020-10-29 18:13 ` Marek Behún
2020-10-29 21:32 ` Ben Whitten
2020-10-29 22:49 ` Jacek Anaszewski
2020-10-29 23:14 ` Marek Behún [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030001445.40154b4a@kernel.org \
--to=kabel@kernel.org \
--cc=ben.whitten@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).