From: Pavel Machek <pavel@ucw.cz>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: linux-leds@vger.kernel.org, "Dan Murphy" <dmurphy@ti.com>,
"Ondřej Jirman" <megous@megous.com>,
"Russell King" <linux@armlinux.org.uk>,
"Andrew Lunn" <andrew@lunn.ch>,
linux-kernel@vger.kernel.org,
"Matthias Schiffer" <matthias.schiffer@ew.tq-group.com>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH leds + devicetree v2 2/2] leds: trigger: netdev: parse `trigger-sources` from device tree
Date: Wed, 25 Nov 2020 11:42:42 +0100 [thread overview]
Message-ID: <20201125104242.GD25562@amd> (raw)
In-Reply-To: <20200915152616.20591-3-marek.behun@nic.cz>
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
Hi!
> Allow setting netdev LED trigger as default when given LED DT node has
> the `trigger-sources` property pointing to a node corresponding to a
> network device.
>
> The specific netdev trigger mode is determined from the `function` LED
> property.
Sounds reasonable.
> + netdev = of_find_net_device_by_node(args.np);
> + if (!netdev)
> + return false;
> +
> + np = dev_of_node(led_cdev->dev);
> + if (!np)
> + return false;
Missing of_node_put?
> +++ b/include/dt-bindings/leds/common.h
> @@ -77,6 +77,7 @@
> #define LED_FUNCTION_HEARTBEAT "heartbeat"
> #define LED_FUNCTION_INDICATOR "indicator"
> #define LED_FUNCTION_LAN "lan"
> +#define LED_FUNCTION_LINK "link"
> #define LED_FUNCTION_MAIL "mail"
> #define LED_FUNCTION_MTD "mtd"
> #define LED_FUNCTION_PANIC "panic"
We have function "lan" already defined; "link" would do mostly same
thing. Should we use "lan"? Or should we delete "lan" and replace it
with "link"?
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-11-25 10:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 15:26 [PATCH leds + devicetree v2 0/2] Parse DT property `trigger-sources` for netdev LED trigger Marek Behún
2020-09-15 15:26 ` [PATCH leds + devicetree v2 1/2] leds: trigger: add trigger sources validating method and helper functions Marek Behún
2020-09-15 16:24 ` Marek Behun
2020-11-25 10:32 ` Pavel Machek
2020-09-15 15:26 ` [PATCH leds + devicetree v2 2/2] leds: trigger: netdev: parse `trigger-sources` from device tree Marek Behún
2020-09-15 21:35 ` Jacek Anaszewski
2020-09-16 0:15 ` Marek Behun
2020-09-16 21:46 ` Jacek Anaszewski
2020-11-25 10:42 ` Pavel Machek [this message]
2020-11-25 12:19 ` Marek Behun
2020-11-25 10:38 ` [PATCH leds + devicetree v2 0/2] Parse DT property `trigger-sources` for netdev LED trigger Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125104242.GD25562@amd \
--to=pavel@ucw.cz \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marek.behun@nic.cz \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=megous@megous.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).