From: Pavel Machek <pavel@ucw.cz>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: dmurphy@ti.com, jacek.anaszewski@gmail.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] leds: lp50xx: Fix an error handling path in 'lp50xx_probe_dt()'
Date: Wed, 25 Nov 2020 12:01:05 +0100 [thread overview]
Message-ID: <20201125110105.GH25562@amd> (raw)
In-Reply-To: <20200922210515.385099-1-christophe.jaillet@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
On Tue 2020-09-22 23:05:15, Christophe JAILLET wrote:
> In case of memory allocation failure, we must release some resources as
> done in all other error handling paths of the function.
>
> 'goto child_out' instead of a direct return so that 'fwnode_handle_put()'
> is called when we break out of a 'device_for_each_child_node' loop.
>
> Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks, applied.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2020-11-25 11:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 21:05 [PATCH] leds: lp50xx: Fix an error handling path in 'lp50xx_probe_dt()' Christophe JAILLET
2020-09-23 13:27 ` Dan Murphy
2020-09-23 13:35 ` Dan Carpenter
2020-09-23 18:49 ` Christophe JAILLET
2020-09-24 6:49 ` Dan Carpenter
2020-09-28 11:53 ` Heikki Krogerus
2020-11-25 10:46 ` Pavel Machek
2020-11-25 12:16 ` Heikki Krogerus
2020-11-25 11:01 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125110105.GH25562@amd \
--to=pavel@ucw.cz \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).