From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: Marek Behun <kabel@blackhole.sk>,
Gabriel David <ultracoolguy4@protonmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] leds: lm3697: Rename struct into more appropriate name
Date: Wed, 25 Nov 2020 12:25:59 +0100 [thread overview]
Message-ID: <20201125112559.GD29328@amd> (raw)
In-Reply-To: <3f83953a-57ba-1fdc-f3ae-d3679e05474d@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]
Hi!
> > From the perspective of Linux you see the two control banks as 2 LED
> >class devices (because you are setting brightness for control banks,
> >not for the LED strips).
>
> The way Marek explains it is correct and the way I wrote the driver
> intially. There is no direct control of the LEDs only controlling the 2
> banks.
>
> As an example a device can put LED string 1 and 2 on a single bank to
> control the backlight for a display and put LED string 3 on a different bank
> to control the backlight of a keyboard. Like in the Droid and Droid 4
> devices. 2 strings illuminate the display backlight and 1 string
> illuminates the keyboard the display backlight can have a independent
> brightness then the keyboard.
>
> To me the name of the structure does not impose any functional changes just
> semantic changes. And it just makes it a bit more difficult to back port
> functional fixes as this patch would be made mandatory for cherry picking.
> But I do not get many requests to back port this driver so it maybe be a
> moot point.
Ok, sorry for the confusion, and .. I believe the code can stay as-is.
Bank is single entity Linux controls, and it does not need to know how
many pins are really controlled on the hardware level.
It will be confusing one way or another.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2020-11-25 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 15:51 [PATCH v2] leds: lm3697: Rename struct into more appropriate name Gabriel David
2020-10-10 18:57 ` Pavel Machek
2020-10-10 21:50 ` Marek Behun
2020-10-12 14:27 ` Dan Murphy
2020-11-25 11:25 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125112559.GD29328@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=kabel@blackhole.sk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=ultracoolguy4@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).